netfilter: nf_tables: reduce set element transaction size
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 0 repliesNew
- v45 patches 6 repliesSuperseded
- v35 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 1 reply | Applied | |
| v1 | 5 patches | 0 replies | Superseded |
Changes in v4 from the cover letter
fix a typo in patch 3 commit message.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | netfilter: nf_tables: add nft_trans_commit_list_add_elem helpernet/ | +16 | 0 replies | |
| 2/5 | netfilter: nf_tables: prepare for multiple elements in nft_trans_elem structureinclude/ net/ | +173 | 0 replies | |
| 3/5 | netfilter: nf_tables: prepare nft audit for set element compactionnet/ | +18 | 0 replies | |
| 4/5 | netfilter: nf_tables: switch trans_elem to real flex arraynet/ | +90 | 0 replies | |
| 5/5 | netfilter: nf_tables: allocate element update information dynamicallyinclude/ net/ | +43 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH nf-next v5 0/5] netfilter: nf_tables: reduce set element transaction size
v5: rework patch 3 commit message.
update/add comments in patch 5.
replace list init by comment in patch 5.
No other changes.
Changes in v4:
fix a typo in patch 3 commit message.
Changes in v3:
I failed to realize that nft_audit leaks one implementation detail to userspace: the length of the transaction log.
This gets fixed by patch 3 which adds needed helper to increment the count variable by the number of elements carried by the compacted set update.
Also fix up notifications, for update case, notifications were skipped but currently newsetelem notifications are done even if existing set element is updated.
Most patches are unchanged.
"prefer nft_trans_elem_alloc helper" is already upstreamed so its dropped from this batch.
v2: only change is in patch 3, and by extension, the last one:
During transaction abort, we need to handle an aggregate container to contain both new set elements and updates. The latter must be skipped, else we remove element that already existed at start of the transaction.
original cover letter:
When doing a flush on a set or mass adding/removing elements from a set, each element needs to allocate 96 bytes to hold the transactional state.
In such cases, virtually all the information in struct nft_trans_elem is the same.
Change nft_trans_elem to a flex-array, i.e. a single nft_trans_elem can hold multiple set element pointers.
The number of elements that can be stored in one nft_trans_elem is limited by the slab allocator, this series limits the compaction to at most 62 elements as it caps the reallocation to 2048 bytes of memory.
Florian Westphal (5):
netfilter: nf_tables: add nft_trans_commit_list_add_elem helper
netfilter: nf_tables: prepare for multiple elements in nft_trans_elem
structure
netfilter: nf_tables: prepare nft audit for set element compaction
netfilter: nf_tables: switch trans_elem to real flex array
netfilter: nf_tables: allocate element update information dynamically
include/net/netfilter/nf_tables.h | 25 +- net/netfilter/nf_tables_api.c | 385 ++++++++++++++++++++++++------ 2 files changed, 321 insertions(+), 89 deletions(-)
Signature · 1 line
2.45.2