Skip to content

i2c: isch: Put the driver into shape

Andy Shevchenko linux-i2c lkml 2 versions – Applied

Status from this message: Applied to i2c/i2c-host-for-6.13. These patches will be moved

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 1 replyApplied
  2. v112 patches 15 repliesApplied

Changes in v2 from the cover letter

- dropped applied patch
- fixed format specifier (LKP)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/11i2c: isch: Pass pointer to struct i2c_adapter downdrivers/i2c/busses/i2c-isch.c+23 -300 replies
2/11i2c: isch: Use string_choices API instead of ternary operatordrivers/i2c/busses/i2c-isch.c+3 -20 replies
3/11i2c: isch: Switch to memory mapped IO accessorsdrivers/i2c/busses/i2c-isch.c+78 -550 replies
4/11i2c: isch: Use custom private data structuredrivers/i2c/busses/i2c-isch.c+75 -700 replies
5/11i2c: isch: switch i2c registration to devm functionsdrivers/i2c/busses/i2c-isch.c+1 -160 replies
6/11i2c: isch: Utilize temporary variable to hold device pointerdrivers/i2c/busses/i2c-isch.c+9 -100 replies
7/11i2c: isch: Use read_poll_timeout()drivers/i2c/busses/i2c-isch.c+6 -140 replies
8/11i2c: isch: Unify the name of the variable to hold an error codedrivers/i2c/busses/i2c-isch.c+7 -80 replies
9/11i2c: isch: Don't use "proxy" headersdrivers/i2c/busses/i2c-isch.c+5 -30 replies
10/11i2c: isch: Prefer to use octal permissiondrivers/i2c/busses/i2c-isch.c+1 -10 replies
11/11i2c: isch: Convert to kernel-docdrivers/i2c/busses/i2c-isch.c+28 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/11] i2c: isch: Put the driver into shape

Driver code is quite outdated WRT modern in-kernel APIs and also has one non-critival bug.

The series is to address the above. Has been tested on Minnowboard (Intel Tunnel Creek platform) with connected LM95245 HW monitor chip.

v2:
- dropped applied patch
- fixed format specifier (LKP)

Andy Shevchenko (11):
i2c: isch: Pass pointer to struct i2c_adapter down
i2c: isch: Use string_choices API instead of ternary operator
i2c: isch: Switch to memory mapped IO accessors
i2c: isch: Use custom private data structure
i2c: isch: switch i2c registration to devm functions
i2c: isch: Utilize temporary variable to hold device pointer
i2c: isch: Use read_poll_timeout()
i2c: isch: Unify the name of the variable to hold an error code
i2c: isch: Don't use "proxy" headers
i2c: isch: Prefer to use octal permission
i2c: isch: Convert to kernel-doc

 drivers/i2c/busses/i2c-isch.c | 321 +++++++++++++++++-----------------
 1 file changed, 164 insertions(+), 157 deletions(-)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac