Python module cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest22 patches 2 repliesIn review
- v622 patches 6 repliesSuperseded
- v521 patches 31 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 19 patches | 2 replies | Superseded | |
| v3 | 16 patches | 0 replies | Superseded | |
| v2 | 16 patches | 6 replies | Superseded | |
| v1 | 2 patches | 9 replies | Superseded |
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | perf python: Remove python 2 scripting supporttools/ tools/ tools/ | +15 | 0 replies | |
| 2/22 | perf python: Constify variables and parameterstools/ | +29 | 0 replies | |
| 3/22 | perf python: Remove unused #includetools/ | +0 | 0 replies | |
| 4/22 | perf script: Move scripting_max_stack out of builtintools/ tools/ tools/ | +3 | 0 replies | |
| 5/22 | perf kvm: Move functions used in util out of builtintools/ tools/ tools/ +2 more | +74 | 0 replies | |
| 6/22 | perf script: Use openat for directory iterationtools/ tools/ tools/ | +71 | 0 replies | |
| 7/22 | perf script: Move find_scripts to browser/scripts.ctools/ tools/ tools/ +1 more | +175 | 0 replies | |
| 8/22 | perf stat: Move stat_config into config.ctools/ tools/ tools/ +3 more | +38 | 0 replies | |
| 9/22 | perf script: Move script_spec code to trace-event-scripting.ctools/ tools/ tools/ +1 more | +80 | 0 replies | |
| 10/22 | perf script: Move script_fetch_insn to trace-event-scripting.ctools/ tools/ tools/ +3 more | +19 | 0 replies | |
| 11/22 | perf script: Move perf_sample__sprintf_flags to trace-event-scripting.ctools/ tools/ tools/ | +83 | 0 replies | |
| 12/22 | perf x86: Define arch_fetch_insn in NO_AUXTRACE buildstools/ tools/ tools/ +2 more | +19 | 0 replies | |
| 13/22 | perf intel-pt: Remove stale build commenttools/ | +0 | 0 replies | |
| 14/22 | perf env: Move arch errno function to only use in envtools/ tools/ tools/ +2 more | +6 | 0 replies | |
| 15/22 | perf lock: Move common lock contention code to new filetools/ tools/ tools/ +3 more | +160 | 1 reply | |
| 16/22 | perf bench: Remove reference to cmd_injecttools/ tools/ tools/ | +12 | 0 replies | |
| 17/22 | perf kwork: Make perf_kwork_add_work a callbacktools/ tools/ tools/ +2 more | +8 | 0 replies | |
| 18/22 | perf build: Remove test library from python shared objecttools/ | +1 | 0 replies | |
| 19/22 | perf python: Add parse_events functiontools/ tools/ tools/ +1 more | +75 | 0 replies | |
| 20/22 | perf python: Add __str__ and __repr__ functions to evlisttools/ | +26 | 0 replies | |
| 21/22 | perf python: Add __str__ and __repr__ functions to evseltools/ | +13 | 0 replies | |
| 22/22 | perf python: Correctly throw IndexErrortools/ | +3 | 0 replies |
Reviews trailers per patch
14 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Arnaldo Carvalho de Melo | Namhyung Kim | Adrian Hunter |
|---|---|---|---|
| 1/22 | A-b | ||
| 2/22 | A-b | ||
| 3/22 | A-b | ||
| 4/22 | A-b | ||
| 5/22 | A-b | ||
| 6/22 | A-b | ||
| 7/22 | A-b | ||
| 8/22 | A-b | ||
| 9/22 | A-b | ||
| 10/22 | A-b | ||
| 11/22 | |||
| 12/22 | T-b | ||
| 13/22 | A-b | ||
| 14/22 | A-b | ||
| 15/22 | A-b | A-b | |
| 16/22 | |||
| 17/22 | |||
| 18/22 | A-b | ||
| 19/22 | |||
| 20/22 | T-b | ||
| 21/22 | T-b | ||
| 22/22 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v7 00/22] Python module cleanup
This patch:
- removes workarounds for Python 2 module support due to long deprecation and challenges in developing new code;
- constifies variables and parameters to functions;
- removes python.c stub code which existed due to missing functions that are defined in the builtin-* files, in general the builtin-* code is moved into util;
- remove bench and test perf C code from the python module;
- adds parse_events to the python perf module.
- improves upon some of the existing python perf module functins.
v7. Move ifdef-ed function stubs into header file for Namhyung. v6. Rebase. When moving find_scripts, separate the switch to using
is_directory_at into a patch before moving the function, Arnaldo/Namhyung. Add acked/tested tags from Arnaldo and Adrian.
v5. Rebase. Fix NO_LIBBPF and NO_AUXTRACE related build failures
caught by Arnaldo and the build-test. Fix NO_AUXTRACE x86 arch_fetch_insn in the process, which was incorrectly using an empty weak symbol stub.
v4. Rebase. Fix the parse events evsel to be embedded in a
pyrf_evsel. Add __str__/__repr__ functions to evlist and evsel. Throw an exception for a bad evlist index.
v3. Move is_directory_at to patch 6 rather than patch 7, respond to
review feedback on the list from Namhyung.
v2. Add the bottom 4 bullet points - 13 more patches.
Ian Rogers (22):
perf python: Remove python 2 scripting support
perf python: Constify variables and parameters
perf python: Remove unused #include
perf script: Move scripting_max_stack out of builtin perf kvm: Move functions used in util out of builtin perf script: Use openat for directory iteration
perf script: Move find_scripts to browser/scripts.c perf stat: Move stat_config into config.c
perf script: Move script_spec code to trace-event-scripting.c perf script: Move script_fetch_insn to trace-event-scripting.c perf script: Move perf_sample__sprintf_flags to
trace-event-scripting.c
perf x86: Define arch_fetch_insn in NO_AUXTRACE builds perf intel-pt: Remove stale build comment
perf env: Move arch errno function to only use in env perf lock: Move common lock contention code to new file perf bench: Remove reference to cmd_inject
perf kwork: Make perf_kwork_add_work a callback
perf build: Remove test library from python shared object perf python: Add parse_events function
perf python: Add __str__ and __repr__ functions to evlist perf python: Add __str__ and __repr__ functions to evsel perf python: Correctly throw IndexError
tools/perf/Makefile.perf | 7 +- tools/perf/arch/x86/util/Build | 2 +- tools/perf/bench/inject-buildid.c | 13 +- tools/perf/builtin-kvm.c | 61 ---- tools/perf/builtin-kwork.c | 3 +- tools/perf/builtin-lock.c | 137 +------ tools/perf/builtin-script.c | 304 +--------------- tools/perf/builtin-stat.c | 27 -- tools/perf/builtin-trace.c | 1 - tools/perf/builtin.h | 6 - .../scripts/python/Perf-Trace-Util/Context.c | 20 +- tools/perf/tests/stat.c | 16 +- tools/perf/trace/beauty/arch_errno_names.sh | 3 +- tools/perf/ui/browsers/scripts.c | 177 ++++++++- tools/perf/util/Build | 4 +- tools/perf/util/bpf_kwork.c | 2 +- tools/perf/util/bpf_kwork_top.c | 2 +- tools/perf/util/bpf_lock_contention.c | 2 +- tools/perf/util/cgroup.c | 2 +- tools/perf/util/config.c | 27 ++ tools/perf/util/dlfilter.c | 3 +- tools/perf/util/env.c | 4 + tools/perf/util/env.h | 2 - tools/perf/util/evsel.c | 19 +- tools/perf/util/evsel.h | 2 +- tools/perf/util/intel-pt-decoder/Build | 18 +- .../intel-pt-decoder/intel-pt-insn-decoder.c | 3 - tools/perf/util/kvm-stat.c | 70 ++++ tools/perf/util/kvm-stat.h | 3 + tools/perf/util/kwork.h | 6 +- tools/perf/util/lock-contention.c | 143 ++++++++ tools/perf/util/lock-contention.h | 18 +- tools/perf/util/path.c | 10 + tools/perf/util/path.h | 1 + tools/perf/util/python.c | 341 ++++++++---------- .../scripting-engines/trace-event-python.c | 63 +--- tools/perf/util/stat.h | 3 +- tools/perf/util/trace-event-scripting.c | 177 +++++++++ tools/perf/util/trace-event.h | 5 +- 39 files changed, 847 insertions(+), 860 deletions(-) create mode 100644 tools/perf/util/kvm-stat.c create mode 100644 tools/perf/util/lock-contention.c
Signature · 1 line
2.47.0.338.g60cca15819-goog