Skip to content

Python module cleanup

Ian Rogers linux-perf-users lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest22 patches 2 repliesIn review
  2. v622 patches 6 repliesSuperseded
  3. v521 patches 31 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v419 patches2 repliesSuperseded
v316 patches0 repliesSuperseded
v216 patches6 repliesSuperseded
v12 patches9 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22perf python: Remove python 2 scripting supporttools/perf/scripts/python/Perf-Trace-Util/Context.c tools/perf/util/python.c tools/perf/util/scripting-engines/trace-event-python.c+15 -1390 replies
2/22perf python: Constify variables and parameterstools/perf/util/python.c+29 -260 replies
3/22perf python: Remove unused #includetools/perf/util/python.c+0 -10 replies
4/22perf script: Move scripting_max_stack out of builtintools/perf/builtin-script.c tools/perf/util/python.c tools/perf/util/trace-event-scripting.c+3 -40 replies
5/22perf kvm: Move functions used in util out of builtintools/perf/builtin-kvm.c tools/perf/util/Build tools/perf/util/kvm-stat.c +2 more+74 -930 replies
6/22perf script: Use openat for directory iterationtools/perf/builtin-script.c tools/perf/util/path.c tools/perf/util/path.h+71 -270 replies
7/22perf script: Move find_scripts to browser/scripts.ctools/perf/builtin-script.c tools/perf/builtin.h tools/perf/ui/browsers/scripts.c +1 more+175 -1850 replies
8/22perf stat: Move stat_config into config.ctools/perf/builtin-script.c tools/perf/builtin-stat.c tools/perf/tests/stat.c +3 more+38 -460 replies
9/22perf script: Move script_spec code to trace-event-scripting.ctools/perf/builtin-script.c tools/perf/util/python.c tools/perf/util/trace-event-scripting.c +1 more+80 -700 replies
10/22perf script: Move script_fetch_insn to trace-event-scripting.ctools/perf/builtin-script.c tools/perf/scripts/python/Perf-Trace-Util/Context.c tools/perf/util/dlfilter.c +3 more+19 -230 replies
11/22perf script: Move perf_sample__sprintf_flags to trace-event-scripting.ctools/perf/builtin-script.c tools/perf/util/python.c tools/perf/util/trace-event-scripting.c+83 -870 replies
12/22perf x86: Define arch_fetch_insn in NO_AUXTRACE buildstools/perf/arch/x86/util/Build tools/perf/util/Build tools/perf/util/intel-pt-decoder/Build +2 more+19 -100 replies
13/22perf intel-pt: Remove stale build commenttools/perf/util/intel-pt-decoder/Build+0 -20 replies
14/22perf env: Move arch errno function to only use in envtools/perf/builtin-trace.c tools/perf/trace/beauty/arch_errno_names.sh tools/perf/util/env.c +2 more+6 -100 replies
15/22perf lock: Move common lock contention code to new filetools/perf/builtin-lock.c tools/perf/util/Build tools/perf/util/bpf_lock_contention.c +3 more+160 -1581 reply
16/22perf bench: Remove reference to cmd_injecttools/perf/Makefile.perf tools/perf/bench/inject-buildid.c tools/perf/util/python.c+12 -140 replies
17/22perf kwork: Make perf_kwork_add_work a callbacktools/perf/builtin-kwork.c tools/perf/util/bpf_kwork.c tools/perf/util/bpf_kwork_top.c +2 more+8 -170 replies
18/22perf build: Remove test library from python shared objecttools/perf/Makefile.perf+1 -10 replies
19/22perf python: Add parse_events functiontools/perf/util/cgroup.c tools/perf/util/evsel.c tools/perf/util/evsel.h +1 more+75 -90 replies
20/22perf python: Add __str__ and __repr__ functions to evlisttools/perf/util/python.c+26 -00 replies
21/22perf python: Add __str__ and __repr__ functions to evseltools/perf/util/python.c+13 -00 replies
22/22perf python: Correctly throw IndexErrortools/perf/util/python.c+3 -10 replies

Reviews trailers per patch

14 of 22 patches have a Reviewed-by or Acked-by.

PatchArnaldo Carvalho de MeloNamhyung KimAdrian Hunter
1/22A-b
2/22A-b
3/22A-b
4/22A-b
5/22A-b
6/22A-b
7/22A-b
8/22A-b
9/22A-b
10/22A-b
11/22
12/22T-b
13/22A-b
14/22A-b
15/22A-b A-b
16/22
17/22
18/22A-b
19/22
20/22T-b
21/22T-b
22/22T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/22] Python module cleanup

This patch:
- removes workarounds for Python 2 module support due to long deprecation and challenges in developing new code;
- constifies variables and parameters to functions;
- removes python.c stub code which existed due to missing functions that are defined in the builtin-* files, in general the builtin-* code is moved into util;
- remove bench and test perf C code from the python module;
- adds parse_events to the python perf module.
- improves upon some of the existing python perf module functins.

v7. Move ifdef-ed function stubs into header file for Namhyung. v6. Rebase. When moving find_scripts, separate the switch to using
is_directory_at into a patch before moving the function, Arnaldo/Namhyung. Add acked/tested tags from Arnaldo and Adrian.
v5. Rebase. Fix NO_LIBBPF and NO_AUXTRACE related build failures
caught by Arnaldo and the build-test. Fix NO_AUXTRACE x86 arch_fetch_insn in the process, which was incorrectly using an empty weak symbol stub.
v4. Rebase. Fix the parse events evsel to be embedded in a
pyrf_evsel. Add __str__/__repr__ functions to evlist and evsel. Throw an exception for a bad evlist index.
v3. Move is_directory_at to patch 6 rather than patch 7, respond to
review feedback on the list from Namhyung.
v2. Add the bottom 4 bullet points - 13 more patches.

Ian Rogers (22):
perf python: Remove python 2 scripting support
perf python: Constify variables and parameters
perf python: Remove unused #include
perf script: Move scripting_max_stack out of builtin perf kvm: Move functions used in util out of builtin perf script: Use openat for directory iteration
perf script: Move find_scripts to browser/scripts.c perf stat: Move stat_config into config.c
perf script: Move script_spec code to trace-event-scripting.c perf script: Move script_fetch_insn to trace-event-scripting.c perf script: Move perf_sample__sprintf_flags to
trace-event-scripting.c
perf x86: Define arch_fetch_insn in NO_AUXTRACE builds perf intel-pt: Remove stale build comment
perf env: Move arch errno function to only use in env perf lock: Move common lock contention code to new file perf bench: Remove reference to cmd_inject
perf kwork: Make perf_kwork_add_work a callback
perf build: Remove test library from python shared object perf python: Add parse_events function
perf python: Add __str__ and __repr__ functions to evlist perf python: Add __str__ and __repr__ functions to evsel perf python: Correctly throw IndexError

 tools/perf/Makefile.perf                      |   7 +-
 tools/perf/arch/x86/util/Build                |   2 +-
 tools/perf/bench/inject-buildid.c             |  13 +-
 tools/perf/builtin-kvm.c                      |  61 ----
 tools/perf/builtin-kwork.c                    |   3 +-
 tools/perf/builtin-lock.c                     | 137 +------
 tools/perf/builtin-script.c                   | 304 +---------------
 tools/perf/builtin-stat.c                     |  27 --
 tools/perf/builtin-trace.c                    |   1 -
 tools/perf/builtin.h                          |   6 -
 .../scripts/python/Perf-Trace-Util/Context.c  |  20 +-
 tools/perf/tests/stat.c                       |  16 +-
 tools/perf/trace/beauty/arch_errno_names.sh   |   3 +-
 tools/perf/ui/browsers/scripts.c              | 177 ++++++++-
 tools/perf/util/Build                         |   4 +-
 tools/perf/util/bpf_kwork.c                   |   2 +-
 tools/perf/util/bpf_kwork_top.c               |   2 +-
 tools/perf/util/bpf_lock_contention.c         |   2 +-
 tools/perf/util/cgroup.c                      |   2 +-
 tools/perf/util/config.c                      |  27 ++
 tools/perf/util/dlfilter.c                    |   3 +-
 tools/perf/util/env.c                         |   4 +
 tools/perf/util/env.h                         |   2 -
 tools/perf/util/evsel.c                       |  19 +-
 tools/perf/util/evsel.h                       |   2 +-
 tools/perf/util/intel-pt-decoder/Build        |  18 +-
 .../intel-pt-decoder/intel-pt-insn-decoder.c  |   3 -
 tools/perf/util/kvm-stat.c                    |  70 ++++
 tools/perf/util/kvm-stat.h                    |   3 +
 tools/perf/util/kwork.h                       |   6 +-
 tools/perf/util/lock-contention.c             | 143 ++++++++
 tools/perf/util/lock-contention.h             |  18 +-
 tools/perf/util/path.c                        |  10 +
 tools/perf/util/path.h                        |   1 +
 tools/perf/util/python.c                      | 341 ++++++++----------
 .../scripting-engines/trace-event-python.c    |  63 +---
 tools/perf/util/stat.h                        |   3 +-
 tools/perf/util/trace-event-scripting.c       | 177 +++++++++
 tools/perf/util/trace-event.h                 |   5 +-
 39 files changed, 847 insertions(+), 860 deletions(-)
 create mode 100644 tools/perf/util/kvm-stat.c
 create mode 100644 tools/perf/util/lock-contention.c
Signature · 1 line
2.47.0.338.g60cca15819-goog