Skip to content

i2c: designware: Cleanups (part 4)

Andy Shevchenko linux-i2c lkml 1 version Applied

Status from this message: merged to i2c/i2c-host.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5i2c: designware: Use temporary variable for struct devicedrivers/i2c/busses/i2c-designware-pcidrv.c drivers/i2c/busses/i2c-designware-platdrv.c+37 -400 replies
2/5i2c: designware: Get rid of redundant 'else'drivers/i2c/busses/i2c-designware-common.c+3 -30 replies
3/5i2c: designware: Remove 'cond' from i2c_dw_scl_hcnt()drivers/i2c/busses/i2c-designware-common.c drivers/i2c/busses/i2c-designware-core.h drivers/i2c/busses/i2c-designware-master.c+16 -420 replies
4/5i2c: designware: Use sda_hold_time variable name everywheredrivers/i2c/busses/i2c-designware-pcidrv.c+5 -50 replies
5/5i2c: designware: Fix spelling and other issues in the commentsdrivers/i2c/busses/i2c-designware-amdpsp.c drivers/i2c/busses/i2c-designware-common.c drivers/i2c/busses/i2c-designware-core.h +3 more+29 -220 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndi ShytiMario LimoncielloJarkko Nikula
SeriesA-b
1/5R-b R-b
2/5R-b R-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/5] i2c: designware: Cleanups (part 4)

This is the subset of the patches [1] that should not affect any functionality. Here are:
- tiding up the probe and remove functions
- dead and redundant code removal
- spelling fixes

In any case this is Cc'ed to AMD who reported a problem in [1] presumably in the patch that is *not* included here.

This is assumed to be the last straightforward patch series to clean up the driver. The rest is directly related or dependent on the reported problem and needs more thinking and work. Perhaps I can do it in the future.

Andy Shevchenko (5):
i2c: designware: Use temporary variable for struct device
i2c: designware: Get rid of redundant 'else'
i2c: designware: Remove 'cond' from i2c_dw_scl_hcnt()
i2c: designware: Use sda_hold_time variable name everywhere
i2c: designware: Fix spelling and other issues in the comments

 drivers/i2c/busses/i2c-designware-amdpsp.c  | 10 ++--
 drivers/i2c/busses/i2c-designware-common.c  | 66 +++++++--------------
 drivers/i2c/busses/i2c-designware-core.h    | 12 ++--
 drivers/i2c/busses/i2c-designware-master.c  | 17 +++---
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 39 ++++++------
 drivers/i2c/busses/i2c-designware-platdrv.c | 52 ++++++++--------
 drivers/i2c/busses/i2c-designware-slave.c   |  6 +-
 7 files changed, 90 insertions(+), 112 deletions(-)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac