Skip to content

drm: Introduce DRM client library

Thomas Zimmermann amd-gfx dri-devel intel-gfx intel-xe stable 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 0 repliesNew
  2. v312 patches 13 repliesSuperseded
  3. v211 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches8 repliesSuperseded

Changes in v4 from the cover letter

- improve commit descriptions (Jonathan) v3:
- fix more corner Kconfig cases (kernel test robot) v2:
- rework of the overall design
- keep base client code in DRM core

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/i915: Select DRM_CLIENT_SELECTIONdrivers/gpu/drm/i915/Kconfig+1 -00 replies
2/12drm/xe: Select DRM_CLIENT_SELECTIONdrivers/gpu/drm/xe/Kconfig+1 -00 replies
3/12drm/fbdev-dma: Select FB_DEFERRED_IOdrivers/gpu/drm/Kconfig+1 -10 replies
4/12drm/fbdev: Select fbdev I/O helpers from modules that require themdrivers/gpu/drm/Kconfig+2 -10 replies
5/12drm/fbdev: Store fbdev module parameters in separate filedrivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/drm_internal.h drivers/gpu/drm/drm_kms_helper_common.c+42 -310 replies
6/12drm/client: Move client event handlers to drm_client_event.cDocumentation/gpu/drm-client.rst drivers/gpu/drm/Makefile drivers/gpu/drm/drm_client.c +8 more+156 -1300 replies
7/12drm/client: Move suspend/resume into DRM client callbacksdrivers/gpu/drm/drm_client_event.c drivers/gpu/drm/drm_fbdev_client.c drivers/gpu/drm/drm_modeset_helper.c +2 more+133 -80 replies
8/12drm/amdgpu: Suspend and resume internal clients with client helpersdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+11 -110 replies
9/12drm/nouveau: Suspend and resume clients with client helpersdrivers/gpu/drm/nouveau/nouveau_display.c+3 -50 replies
10/12drm/radeon: Suspend and resume clients with client helpersdrivers/gpu/drm/radeon/radeon_device.c drivers/gpu/drm/radeon/radeon_fbdev.c drivers/gpu/drm/radeon/radeon_mode.h+10 -180 replies
11/12drm/client: Make client support optionaldrivers/gpu/drm/Kconfig drivers/gpu/drm/Makefile drivers/gpu/drm/amd/amdgpu/Kconfig +5 more+38 -60 replies
12/12drm/client: Add client-lib moduledrivers/gpu/drm/Kconfig drivers/gpu/drm/Makefile drivers/gpu/drm/drm_client_setup.c +1 more+37 -90 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJonathan Cavitt
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] drm: Introduce DRM client library

With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it is time to provide a single place for the clients.

The base client code and client event handling is now optional. It still remains in the DRM core, which simplifies module dependencies. The new module drm_client_lib.ko stores most of the in-kernel client code. Drivers can opt into client support, but the presence of the client module depends on the user's kernel configuration. Without selected clients, no client module will be build.

DRM now forwards suspend and resume events to client helpers instead of calling fbdev emulation directly. This breaks a cyclic dependency among the involved modules. It also allows any client to process suspend and resume events.

v4:
- improve commit descriptions (Jonathan) v3:
- fix more corner Kconfig cases (kernel test robot) v2:
- rework of the overall design
- keep base client code in DRM core

Thomas Zimmermann (12):
drm/i915: Select DRM_CLIENT_SELECTION
drm/xe: Select DRM_CLIENT_SELECTION
drm/fbdev-dma: Select FB_DEFERRED_IO
drm/fbdev: Select fbdev I/O helpers from modules that require them drm/fbdev: Store fbdev module parameters in separate file drm/client: Move client event handlers to drm_client_event.c drm/client: Move suspend/resume into DRM client callbacks drm/amdgpu: Suspend and resume internal clients with client helpers drm/nouveau: Suspend and resume clients with client helpers drm/radeon: Suspend and resume clients with client helpers drm/client: Make client support optional
drm/client: Add client-lib module

 Documentation/gpu/drm-client.rst              |   3 +
 drivers/gpu/drm/Kconfig                       |  41 +++-
 drivers/gpu/drm/Makefile                      |  20 +-
 drivers/gpu/drm/amd/amdgpu/Kconfig            |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  22 +-
 drivers/gpu/drm/drm_client.c                  | 121 -----------
 drivers/gpu/drm/drm_client_event.c            | 197 ++++++++++++++++++
 drivers/gpu/drm/drm_client_setup.c            |   3 +
 drivers/gpu/drm/drm_debugfs.c                 |   1 -
 drivers/gpu/drm/drm_drv.c                     |   2 +-
 drivers/gpu/drm/drm_fb_helper.c               |  31 ---
 drivers/gpu/drm/drm_fbdev_client.c            |  30 ++-
 drivers/gpu/drm/drm_file.c                    |   2 +-
 drivers/gpu/drm/drm_internal.h                |  15 ++
 drivers/gpu/drm/drm_kms_helper_common.c       |  38 ++++
 drivers/gpu/drm/drm_modeset_helper.c          |  14 +-
 drivers/gpu/drm/drm_probe_helper.c            |   2 +-
 drivers/gpu/drm/i915/Kconfig                  |   1 +
 .../drm/i915/display/intel_display_driver.c   |   2 +-
 drivers/gpu/drm/nouveau/nouveau_display.c     |   8 +-
 drivers/gpu/drm/nouveau/nouveau_vga.c         |   2 +-
 drivers/gpu/drm/radeon/radeon_device.c        |  19 +-
 drivers/gpu/drm/radeon/radeon_fbdev.c         |   6 -
 drivers/gpu/drm/radeon/radeon_mode.h          |   3 -
 drivers/gpu/drm/xe/Kconfig                    |   1 +
 include/drm/drm_client.h                      |  41 +++-
 include/drm/drm_client_event.h                |  27 +++
 27 files changed, 434 insertions(+), 219 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_client_event.c
 create mode 100644 include/drm/drm_client_event.h
Signature · 1 line
2.46.0