Skip to content

Enhance event delivery error handling

Ivan Orlov kvm linux-kselftest lkml 3 versions – Applied

Status from this message: Applied to kvm-x86 misc, thanks! If you get a chance, please double check that

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 10 repliesApplied
  2. v26 patches 14 repliesSuperseded
  3. v13 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- Make the new X86EMUL_ code more generic
- Prohibit any emulation during vectoring if it is due to an intercepted #PF
- Add a new patch for checking whether unprotect & retry is possible before exiting to userspace due to unhandleable vectoring
- Codestyle fixes

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7KVM: x86: Add function for vectoring error generationarch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c+29 -120 replies
2/7KVM: x86: Add emulation status for unhandleable vectoringarch/x86/kvm/kvm_emulate.h arch/x86/kvm/x86.c+7 -01 reply
3/7KVM: x86: Unprotect & retry before unhandleable vectoring checkarch/x86/kvm/x86.c+4 -00 replies
4/7KVM: VMX: Handle vectoring error in check_emulate_instructionarch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/vmx.c+16 -162 replies
5/7KVM: SVM: Handle vectoring error in check_emulate_instructionarch/x86/kvm/svm/svm.c+6 -01 reply
6/7selftests: KVM: extract lidt into helper functiontools/testing/selftests/kvm/include/x86_64/processor.h tools/testing/selftests/kvm/set_memory_region_test.c tools/testing/selftests/kvm/x86_64/sev_smoke_test.c+7 -21 reply
7/7selftests: KVM: Add test case for MMIO during vectoringtools/testing/selftests/kvm/include/x86_64/processor.h tools/testing/selftests/kvm/set_memory_region_test.c+53 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] Enhance event delivery error handling

Currently, the unhandleable vectoring (e.g. when guest accesses MMIO during vectoring) is handled differently on VMX and SVM: on VMX KVM returns internal error, when SVM goes into infinite loop trying to deliver an event again and again.

This patch series eliminates this difference by returning a KVM internal error when KVM can't emulate during vectoring for both VMX and SVM.

Also, introduce a selftest test case which covers the error handling mentioned above.

V1 -> V2:
- Make commit messages more brief, avoid using pronouns
- Extract SVM error handling into a separate commit
- Introduce a new X86EMUL_ return type and detect the unhandleable vectoring error in vendor-specific check_emulate_instruction instead of handling it in the common MMU code (which is specific for cached MMIO)

V2 -> V3:
- Make the new X86EMUL_ code more generic
- Prohibit any emulation during vectoring if it is due to an intercepted #PF
- Add a new patch for checking whether unprotect & retry is possible before exiting to userspace due to unhandleable vectoring
- Codestyle fixes

Ivan Orlov (7):
KVM: x86: Add function for vectoring error generation
KVM: x86: Add emulation status for unhandleable vectoring
KVM: x86: Unprotect & retry before unhandleable vectoring check
KVM: VMX: Handle vectoring error in check_emulate_instruction
KVM: SVM: Handle vectoring error in check_emulate_instruction
selftests: KVM: extract lidt into helper function
selftests: KVM: Add test case for MMIO during vectoring

 arch/x86/include/asm/kvm_host.h               | 11 +++-
 arch/x86/kvm/kvm_emulate.h                    |  2 +
 arch/x86/kvm/svm/svm.c                        |  6 +++
 arch/x86/kvm/vmx/vmx.c                        | 30 ++++-------
 arch/x86/kvm/x86.c                            | 31 +++++++++++
 .../selftests/kvm/include/x86_64/processor.h  |  7 +++
 .../selftests/kvm/set_memory_region_test.c    | 53 ++++++++++++++++++-
 .../selftests/kvm/x86_64/sev_smoke_test.c     |  2 +-
 8 files changed, 117 insertions(+), 25 deletions(-)
Signature · 1 line
2.43.0