Skip to content

uprobes: kill xol_area->slot_count

Oleg Nesterov linux-trace-kernel lkml 1 version Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2uprobes: kill xol_area->slot_countkernel/events/uprobes.c+15 -140 replies
2/2uprobes: fold xol_take_insn_slot() into xol_get_insn_slot()kernel/events/uprobes.c+4 -130 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrii Nakryiko
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] uprobes: kill xol_area->slot_count

Hello,

On top of

	[PATCH 0/7] uprobes: deuglify xol_get_insn_slot/xol_free_insn_slot paths
	https://lore.kernel.org/all/[email protected]/

To me this change looks like a simplification, but perhaps it can also be considered as optimization.

Yes, in the contended case xol_get_slot_nr() will be called twice, the second time after prepare_to_wait_event(), but I don't think it can hurt in the slow path when the caller is likely going to sleep.

Oleg.
---

 kernel/events/uprobes.c | 38 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 21 deletions(-)