Skip to content

GPU debug support (eudebug) v2

Mika Kuoppala intel-xe lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18ptrace: export ptrace_may_accesskernel/ptrace.c+1 -00 replies
2/18drm/xe/eudebug: Introduce eudebug supportdrivers/gpu/drm/xe/Kconfig drivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device.c +7 more+1463 -10 replies
3/18drm/xe/eudebug: Introduce discovery for resourcesdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_device_types.h +2 more+185 -73 replies
4/18drm/xe/eudebug: Introduce exec_queue eventsdrivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_eudebug.h drivers/gpu/drm/xe/xe_eudebug_types.h +2 more+240 -20 replies
5/18drm/xe/eudebug: hw enablement for eudebugdrivers/gpu/drm/xe/regs/xe_engine_regs.h drivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_eudebug.c +3 more+91 -00 replies
6/18drm/xe: Add EUDEBUG_ENABLE exec queue propertydrivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h +5 more+74 -100 replies
7/18drm/xe/eudebug: Introduce per device attention scan workerdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/regs/xe_engine_regs.h drivers/gpu/drm/xe/regs/xe_gt_regs.h +8 more+612 -10 replies
8/18drm/xe/eudebug: Introduce EU control interfacedrivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_eudebug_types.h +3 more+561 -200 replies
9/18drm/xe/eudebug: Add vm bind and vm bind opsdrivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_eudebug.h drivers/gpu/drm/xe/xe_eudebug_types.h +3 more+448 -30 replies
10/18drm/xe/eudebug: Add UFENCE events with acksdrivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_eudebug.h drivers/gpu/drm/xe/xe_eudebug_types.h +6 more+377 -280 replies
11/18drm/xe/eudebug: vm open/pread/pwritedrivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_eudebug.c include/uapi/drm/xe_drm_eudebug.h+522 -00 replies
12/18drm/xe/eudebug: implement userptr_vma accessdrivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_vm.c drivers/gpu/drm/xe/xe_vm.h+51 -113 replies
13/18drm/xe: Debug metadata create/destroy ioctlsdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_debug_metadata.c drivers/gpu/drm/xe/xe_debug_metadata.h +6 more+267 -22 replies
14/18drm/xe: Attach debug metadata to vmadrivers/gpu/drm/xe/xe_debug_metadata.c drivers/gpu/drm/xe/xe_debug_metadata.h drivers/gpu/drm/xe/xe_vm.c +2 more+309 -40 replies
15/18drm/xe/eudebug: Add debug metadata support for xe_eudebugdrivers/gpu/drm/xe/xe_debug_metadata.c drivers/gpu/drm/xe/xe_eudebug.c drivers/gpu/drm/xe/xe_eudebug.h +3 more+396 -110 replies
16/18drm/xe/eudebug: Implement vm_bind_op discoverydrivers/gpu/drm/xe/xe_eudebug.c+45 -00 replies
17/18drm/xe/eudebug: Dynamically toggle debugger functionalitydrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_eudebug.c +6 more+133 -320 replies
18/18drm/xe/eudebug_test: Introduce xe_eudebug wa kunit testdrivers/gpu/drm/xe/tests/xe_eudebug.c drivers/gpu/drm/xe/tests/xe_live_test_mod.c drivers/gpu/drm/xe/xe_eudebug.c+184 -00 replies

Reviews trailers per patch

3 of 18 patches have a Reviewed-by or Acked-by.

PatchAndi ShytiJonathan CavittMatthew Brost
1/18R-b
2/18
3/18A-b
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18
12/18R-b
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/18] GPU debug support (eudebug) v2

Hi,

This is a continuation of the first submission for GPU debug support:

https://lists.freedesktop.org/archives/intel-xe/2024-July/043605.html

The most significant changes are:
1. Placing the code behind Kconfig switch

2. Using rw_semaphore to allow resource discovery to run without individual resource locks.

The page fault handling RFC will be based on this series but will be posted separately.

Thanks to all contributors for their feedback on v1 and to patch authors for their fixes. I hope I haven't missed anything.

Mika

Andrzej Hajda (1):
drm/xe/eudebug: implement userptr_vma access

Christoph Manszewski (3):
drm/xe/eudebug: Add vm bind and vm bind ops drm/xe/eudebug: Dynamically toggle debugger functionality drm/xe/eudebug_test: Introduce xe_eudebug wa kunit test

Dominik Grzegorzek (8):
drm/xe/eudebug: Introduce exec_queue events drm/xe/eudebug: hw enablement for eudebug drm/xe: Add EUDEBUG_ENABLE exec queue property drm/xe/eudebug: Introduce per device attention scan worker drm/xe/eudebug: Introduce EU control interface drm/xe: Debug metadata create/destroy ioctls drm/xe: Attach debug metadata to vma drm/xe/eudebug: Add debug metadata support for xe_eudebug

Mika Kuoppala (6):
ptrace: export ptrace_may_access drm/xe/eudebug: Introduce eudebug support drm/xe/eudebug: Introduce discovery for resources drm/xe/eudebug: Add UFENCE events with acks drm/xe/eudebug: vm open/pread/pwrite drm/xe/eudebug: Implement vm_bind_op discovery

 drivers/gpu/drm/xe/Kconfig                   |   10 +
 drivers/gpu/drm/xe/Makefile                  |    4 +
 drivers/gpu/drm/xe/regs/xe_engine_regs.h     |    7 +
 drivers/gpu/drm/xe/regs/xe_gt_regs.h         |   43 +
 drivers/gpu/drm/xe/tests/xe_eudebug.c        |  175 +
 drivers/gpu/drm/xe/tests/xe_live_test_mod.c  |    5 +
 drivers/gpu/drm/xe/xe_debug_metadata.c       |  233 ++
 drivers/gpu/drm/xe/xe_debug_metadata.h       |   98 +
 drivers/gpu/drm/xe/xe_debug_metadata_types.h |   28 +
 drivers/gpu/drm/xe/xe_device.c               |   26 +-
 drivers/gpu/drm/xe/xe_device.h               |   36 +
 drivers/gpu/drm/xe/xe_device_types.h         |   47 +
 drivers/gpu/drm/xe/xe_eudebug.c              | 3891 ++++++++++++++++++
 drivers/gpu/drm/xe/xe_eudebug.h              |   93 +
 drivers/gpu/drm/xe/xe_eudebug_types.h        |  328 ++
 drivers/gpu/drm/xe/xe_exec.c                 |    2 +-
 drivers/gpu/drm/xe/xe_exec_queue.c           |   56 +-
 drivers/gpu/drm/xe/xe_exec_queue.h           |    2 +
 drivers/gpu/drm/xe/xe_exec_queue_types.h     |    7 +
 drivers/gpu/drm/xe/xe_execlist.c             |    2 +-
 drivers/gpu/drm/xe/xe_gt_debug.c             |  148 +
 drivers/gpu/drm/xe/xe_gt_debug.h             |   27 +
 drivers/gpu/drm/xe/xe_hw_engine.c            |    1 +
 drivers/gpu/drm/xe/xe_lrc.c                  |   16 +-
 drivers/gpu/drm/xe/xe_lrc.h                  |    4 +-
 drivers/gpu/drm/xe/xe_reg_sr.c               |   21 +-
 drivers/gpu/drm/xe/xe_reg_sr.h               |    4 +-
 drivers/gpu/drm/xe/xe_rtp.c                  |    2 +-
 drivers/gpu/drm/xe/xe_sync.c                 |   45 +-
 drivers/gpu/drm/xe/xe_sync.h                 |    8 +-
 drivers/gpu/drm/xe/xe_sync_types.h           |   28 +-
 drivers/gpu/drm/xe/xe_vm.c                   |  173 +-
 drivers/gpu/drm/xe/xe_vm.h                   |    3 +
 drivers/gpu/drm/xe/xe_vm_types.h             |   40 +
 drivers/gpu/drm/xe/xe_wa_oob.rules           |    2 +
 include/uapi/drm/xe_drm.h                    |   96 +-
 include/uapi/drm/xe_drm_eudebug.h            |  225 +
 kernel/ptrace.c                              |    1 +
 38 files changed, 5887 insertions(+), 50 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/tests/xe_eudebug.c
 create mode 100644 drivers/gpu/drm/xe/xe_debug_metadata.c
 create mode 100644 drivers/gpu/drm/xe/xe_debug_metadata.h
 create mode 100644 drivers/gpu/drm/xe/xe_debug_metadata_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_eudebug.c
 create mode 100644 drivers/gpu/drm/xe/xe_eudebug.h
 create mode 100644 drivers/gpu/drm/xe/xe_eudebug_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_gt_debug.c
 create mode 100644 drivers/gpu/drm/xe/xe_gt_debug.h
 create mode 100644 include/uapi/drm/xe_drm_eudebug.h
Signature · 1 line
2.34.1