Skip to content

Store overlay real upper file in ovl_file

Amir Goldstein linux-fsdevel linux-unionfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 11 repliesIn review
  2. v24 patches 14 repliesSuperseded
  3. v14 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Simplifications to flow (Al)
- Loose backing_file stash in favor of ovl_file (Miklos)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ovl: do not open non-data lower file for fsyncfs/overlayfs/file.c+43 -285 replies
2/5ovl: allocate a container struct ovl_file for ovl private contextfs/overlayfs/file.c+22 -62 replies
3/5ovl: store upper real file in ovl_file structfs/overlayfs/file.c+41 -80 replies
4/5ovl: convert ovl_real_fdget_path() callers to ovl_real_file_path()fs/overlayfs/file.c+37 -290 replies
5/5ovl: convert ovl_real_fdget() callers to ovl_real_file()fs/overlayfs/file.c+59 -860 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] Store overlay real upper file in ovl_file

Hi all,

This is v3 of the code to avoid temporary backing file opens in overlayfs, taking into account Al's and Miklos' comments on v2 [1].

If no further comments, this is going for overlayfs-next.

Thanks,
Amir.

Changes since v2:
- Simplifications to flow (Al)
- Loose backing_file stash in favor of ovl_file (Miklos)

Changes since v1:
- Use helpers ovl_real_file() and ovl_upper_file() to express that ovl_real_file() cannot return NULL
- Fix readability and bug is code to select and store stashed upperfile

[1] https://lore.kernel.org/linux-unionfs/[email protected]/

Amir Goldstein (5):
ovl: do not open non-data lower file for fsync
ovl: allocate a container struct ovl_file for ovl private context
ovl: store upper real file in ovl_file struct
ovl: convert ovl_real_fdget_path() callers to ovl_real_file_path()
ovl: convert ovl_real_fdget() callers to ovl_real_file()

 fs/overlayfs/file.c | 301 +++++++++++++++++++++++++-------------------
 1 file changed, 173 insertions(+), 128 deletions(-)
Signature · 1 line
2.34.1