Skip to content

Fixes for snapshots + unlink

Kent Overstreet linux-bcachefs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5bcachefs: Split out check_unreachable_inodes() passfs/bcachefs/fsck.c fs/bcachefs/fsck.h fs/bcachefs/recovery_passes_types.h+67 -350 replies
2/5bcachefs: reattach_inode() now correctly handles interior snapshot nodesfs/bcachefs/btree_iter.h fs/bcachefs/fsck.c+158 -200 replies
3/5bcachefs: btree_iter_peek_upto() now handles BTREE_ITER_all_snapshotsfs/bcachefs/btree_iter.c+3 -30 replies
4/5bcachefs: Delete vestigal check_inode() checksfs/bcachefs/fsck.c+5 -750 replies
5/5bcachefs: bcachefs_metadata_version_inode_has_child_snapshotsfs/bcachefs/bcachefs_format.h fs/bcachefs/fs.c fs/bcachefs/fs.h +6 more+261 -780 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Fixes for snapshots + unlink

The handling of unlinked files with snapshots was a bit fubar - especially if an unlinked file was then reattached in a newer snapshot. This adds an inode flag so that we can track when an inode should, or should not be deleted due to snapshots, when a newer snapshot still refers to data in an unlinked file.

Kent Overstreet (5):
bcachefs: Split out check_unreachable_inodes() pass
bcachefs: reattach_inode() now correctly handles interior snapshot
nodes
bcachefs: btree_iter_peek_upto() now handles BTREE_ITER_all_snapshots
bcachefs: Delete vestigal check_inode() checks
bcachefs: bcachefs_metadata_version_inode_has_child_snapshots

 fs/bcachefs/bcachefs_format.h       |   3 +-
 fs/bcachefs/btree_iter.c            |   6 +-
 fs/bcachefs/btree_iter.h            |   8 +
 fs/bcachefs/fs.c                    |  21 +-
 fs/bcachefs/fs.h                    |   9 +-
 fs/bcachefs/fsck.c                  | 377 +++++++++++++++++-----------
 fs/bcachefs/fsck.h                  |   1 +
 fs/bcachefs/inode.c                 | 233 ++++++++++++++---
 fs/bcachefs/inode.h                 |  10 +
 fs/bcachefs/inode_format.h          |   3 +-
 fs/bcachefs/recovery_passes_types.h |   1 +
 fs/bcachefs/sb-downgrade.c          |   5 +-
 fs/bcachefs/sb-errors_format.h      |   4 +-
 13 files changed, 482 insertions(+), 199 deletions(-)
Signature · 1 line
2.45.2