Skip to content

nvme-multipath: fix deadlock in device_add_disk()

Hannes Reinecke linux-nvme 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v13 patches 21 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme: propagate I/O errors during partition scandrivers/nvme/host/core.c drivers/nvme/host/multipath.c drivers/nvme/host/nvme.h+40 -60 replies
2/2nvme-multipath: retry partition scan on errorsdrivers/nvme/host/multipath.c+20 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/2] nvme-multipath: fix deadlock in device_add_disk()

From: Hannes Reinecke <[email protected]>

Hi all,

I'm having a testcase which repeatedly disables namespaces on the target assigning new UUID (to simulate namespace remapping) and enable that namespace again.
To throw in more fun these namespaces have their ANA group ID changes to simulate namespace moving around in a cluster, where only the paths local to the cluster node are active, and all other paths are inaccessible.

Essentially it's doing something like:

echo 0 > ${ns}/enable
<random delay>
echo "<dev>" > ${ns}/device_path
echo "<grpid>" > ${ns}/ana_grpid
uuidgen > ${ns}/device_uuid
echo 1 > ${ns}/enable

ie a similar testcase than the previous patchset, only this time I'm just doing an 'enable/disable' bit without removing the namespace from the target.
This is causing lockups in device_add_disk(), as the partition scan is constantly retrying I/O and never completes.

With this patchset I/O errors during partition scan will never be retried but will cause nvme_mpath_set_live() to fail. This allows us to retry nvme_mpath_set_live() on the next rescan to fixup the situation.

As usual, comments and reviews are welcome.

Changes to the original submission:
- Drop patch to simplify the loop in nvme_update_ana_state()
- Rework patches to return I/O errors during partition scan

Hannes Reinecke (2):
nvme: propagate I/O errors during partition scan
nvme-multipath: retry partition scan on errors

 drivers/nvme/host/core.c      | 26 ++++++++++++++++++------
 drivers/nvme/host/multipath.c | 38 +++++++++++++++++++++++++++++++++++
 drivers/nvme/host/nvme.h      |  2 ++
 3 files changed, 60 insertions(+), 6 deletions(-)
Signature · 1 line
2.35.3