Skip to content

nvme: disable CC.CRIME (NVME_CC_CRIME)

[email protected] linux-nvme 2 versions Applied

Status from this message: Thanks, applied to nvme-6.12.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 7 repliesApplied
  2. v11 patch 1 replySuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/1nvme: disable CC.CRIME (NVME_CC_CRIME)drivers/nvme/host/core.c+8 -67 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

Patch[email protected]
1/1R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/1] nvme: disable CC.CRIME (NVME_CC_CRIME)

From: Greg Joyce <[email protected]>

NVMe 2.0 introduced a configuration setting CC.CRIME that allows the controller to set CSTS.RDY before the media is fully enabled. In this case commands listed in Figure 103 may return the status NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY. The NVMe driver is not coded to handle these failures so initialization errors occur.

Since the current driver does not:
1) retry media not ready errors
2) utilize any parallel initialization that CRIME may provide

setting NVME_CC_CRIME provides no value.

The NVMe 2.0 spec says this about CC.CRIME:
"If the CAP.CRMS field is set to 11b, then both controller
ready modes are supported, and the host may select the controller ready mode by modifying the value of the CC.CRIME bit."

This the CC.CRIME feature is optional and this patch removes it.

Changelog
v2: - remove NVME_CC_CRIME from timeout calculations (Keith Busch)

Greg Joyce (1):
nvme: disable CC.CRIME (NVME_CC_CRIME)

 drivers/nvme/host/core.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
Signature · 1 line
[email protected]