Skip to content

ecryptfs: convert to the new mount API

Eric Sandeen ecryptfs 3 versions – Applied

Status from this message: Applied to the vfs.ecryptfs branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 2 repliesApplied
  2. v2 posting 1/21 patch 2 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2ecryptfs: Factor out mount option validationfs/ecryptfs/ecryptfs_kernel.h fs/ecryptfs/main.c+38 -240 replies
2/2ecryptfs: Convert ecryptfs to use the new mount APIfs/ecryptfs/ecryptfs_kernel.h fs/ecryptfs/main.c+197 -2021 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTyler Hicks
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/2] ecryptfs: convert to the new mount API

This is lightly tested with the kernel tests present in ecryptfs-utils, but it could certainly use a bit more testing and review, particularly with invalid mount option sets.

This one is a little unique compared to other filesystems in that I allocate both an fs context and the *sbi in .init_fs_context; the *sbi is long-lived, and the context is only present during the initial mount.

Allocating sbi with the filesystem context means we can set options into it directly, rather than needing to do it after parsing. And it's particularly simple to do it this way given that there is no remount.

I could squash these two patches into one if you prefer, but I thought maybe breaking out the first change made review a little easier.

V2: Fix whitespace issues and remove an accidental double semicolon
in the 2nd patch.

Thanks,
-Eric