ASoC: SOF: ipc4-topology: Rework the module audio format prints
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 1 replyIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Pierre-Louis Bossart | Bard Liao | Ranjani Sridharan |
|---|---|---|---|
| 1/8 | R-b | R-b | R-b |
| 2/8 | R-b | R-b | R-b |
| 3/8 | R-b | R-b | R-b |
| 4/8 | R-b | R-b | R-b |
| 5/8 | R-b | R-b | R-b |
| 6/8 | R-b | R-b | R-b |
| 7/8 | R-b | R-b | R-b |
| 8/8 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/8] ASoC: SOF: ipc4-topology: Rework the module audio format prints
Hi,
When the audio started we print out here and there the Input and Output or only the Input audio format for the module that is in path of the stream. This is mostly OK but provides inconsistent an - in my opinion - hard to grasp information.
The series reworks how the input/output format is selected and tries to improve the consistency of the prints by applying universal rules:
- Module is not changing the format or it has only input or output and it has single format on in and out side
Audio format for gain.1.1:
- Module is not changing the format or it has only input or output and it has multiple formats on either in or out side
Audio format (in/out format index: 2/0) for host-copier.0.playback:
- Module is changing format then we print the input and output ones
- Input if it has single format
Input audio format for host-copier.0.capture:
- Input has multiple formats
Input audio format (format index: 0) for host-copier.0.playback:
Similar versions for the output format prints.
Regards,
Peter
---
Peter Ujfalusi (8):
ASoC: SOF: ipc4-topology: Drop the 'index' from 'Pin index' of format
print
ASoC: SOF: ipc4-topology: Use local variables in
sof_ipc4_init_input_audio_fmt()
ASoC: SOF: ipc4-topology: Remove redundant check in
sof_ipc4_init_input_audio_fmt()
ASoC: SOF: ipc4-topology: Simplify match format print in
sof_ipc4_init_input_audio_fmt() ASoC: SOF: ipc4-topology: Use local variables in
sof_ipc4_init_output_audio_fmt()
ASoC: SOF: ipc4-topology: Simplify code to deal with process modules
without output
ASoC: SOF: ipc4-topology: Concentrate prints inside of
sof_ipc4_init_output_audio_fmt()
ASoC: SOF: ipc4-topology: Add helper function to print the module's
in/out audio format
sound/soc/sof/ipc4-topology.c | 375 ++++++++++++++++++++++------------ 1 file changed, 248 insertions(+), 127 deletions(-)
Signature · 1 line
2.47.0