Skip to content

SRF: Fix offline CPU preventing pc6 entry

Patryk Wlazlyn linux-pm lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 8 repliesIn review
  2. v84 patches 5 repliesSuperseded
  3. v74 patches 8 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v64 patches4 repliesSuperseded
v53 patches3 repliesSuperseded
v4 RFC8 patches33 repliesSuperseded
v33 patches46 repliesSuperseded
v23 patches10 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v9 from the cover letter

* Revert the deletion of cpuidle_state_table check for enter and s2idle handlers in intel_idle in 3/4:
- if (!cpuidle_state_table[cstate].enter &&
- !cpuidle_state_table[cstate].enter_s2idle)
+ if (!cpuidle_state_table[cstate].enter)

* Apply the changelog wording suggested by Rafael in v8 review.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/smp: Allow calling mwait_play_dead with an arbitrary hintarch/x86/include/asm/smp.h arch/x86/kernel/smpboot.c+51 -420 replies
2/4ACPI: processor_idle: Add FFH state handlingarch/x86/kernel/acpi/cstate.c drivers/acpi/processor_idle.c include/acpi/processor.h+17 -00 replies
3/4intel_idle: Provide the default enter_dead() handlerdrivers/idle/intel_idle.c+15 -01 reply
4/4x86/smp: Eliminate mwait_play_dead_cpuid_hint()arch/x86/kernel/smpboot.c+7 -490 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGautham R. ShenoyRafael J. Wysocki
SeriesA-b
1/4R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/4] SRF: Fix offline CPU preventing pc6 entry

Code for determining the mwait hint for the deepest C-state by inspecting CPUID leaf 0x5 in mwait_play_dead() assumes that, if the number of sub-states for a given major C-state is nonzero, those sub-states are always represented by consecutive numbers starting from
0. This assumption is not based on the documented platform behavior and in fact it is not met on recent Intel platforms.

Changes since v8:
* Revert the deletion of cpuidle_state_table check for enter and s2idle handlers in intel_idle in 3/4:
- if (!cpuidle_state_table[cstate].enter &&
- !cpuidle_state_table[cstate].enter_s2idle)
+ if (!cpuidle_state_table[cstate].enter)

* Apply the changelog wording suggested by Rafael in v8 review.

Patryk Wlazlyn (4):
x86/smp: Allow calling mwait_play_dead with an arbitrary hint
ACPI: processor_idle: Add FFH state handling
intel_idle: Provide the default enter_dead() handler x86/smp: Eliminate mwait_play_dead_cpuid_hint()

 arch/x86/include/asm/smp.h    |  3 +++
 arch/x86/kernel/acpi/cstate.c | 10 ++++++++
 arch/x86/kernel/smpboot.c     | 46 ++++-------------------------------
 drivers/acpi/processor_idle.c |  2 ++
 drivers/idle/intel_idle.c     | 15 ++++++++++++
 include/acpi/processor.h      |  5 ++++
 6 files changed, 40 insertions(+), 41 deletions(-)
Signature · 1 line
2.47.1