Skip to content

Make the Rust linked list cursor point between elements

Alice Ryhl lkml rust-for-linux 7 versions – Applied

Status from this message: Applied to `rust-next` -- thanks everyone!

Get series with b4
b4 am [email protected] change-id 20241016-cursor-between-154bed859e27

Versions newest first

  1. v7 Latest2 patches 1 replyApplied
  2. v62 patches 1 replySuperseded
  3. v52 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches2 repliesSuperseded
v32 patches1 replySuperseded
v22 patches4 repliesSuperseded
v11 patch4 repliesSuperseded

Changes in v7 from the cover letter

- Fix missing mut in v6 as mentioned in reply.
- Rebase on v6.14-rc1.
- Link to v6: https://lore.kernel.org/r/[email protected]

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2rust: list: extract common code for insertionrust/kernel/list.rs+32 -380 replies
2/2rust: list: make the cursor point between elementsrust/kernel/list.rs+347 -540 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndreas HindborgBoqun Feng
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] Make the Rust linked list cursor point between elements

Please see the commit message of the last patch for more details and motivation.

---
Changes in v7:
- Fix missing mut in v6 as mentioned in reply.
- Rebase on v6.14-rc1.
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Fix bug where Cursor::insert_inner does not update self.list.first
when inserting elements at the head of the list.
- Add a new Cursor::insert method. See its implementation for justification.
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Fix list / list2 in example.
- Add remove_last function to example.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Actually call the example functions.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Fix CursorPeek::deref to use self.ptr.
- Reword comment on ArcBorrow in impl Deref for CursorPeek.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Extract insert_inner refactor to separate patch.
- Make move_next/move_prev not wrap around.
- Add some examples.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Alice Ryhl (2):
rust: list: extract common code for insertion
rust: list: make the cursor point between elements

 rust/kernel/list.rs | 471 ++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 379 insertions(+), 92 deletions(-)

---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20241016-cursor-between-154bed859e27

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>