Skip to content

perf tools: Do not set attr.exclude_guest by default (v5)

Namhyung Kim linux-perf-users lkml 1 version Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 1 replyApplied

Patches in v1 Applied

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchIan RogersKan LiangJames ClarkRavi Bangoria
SeriesR-b R-b R-b R-b R-b A-b A-b A-b A-b A-b A-b A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCHSET 0/9] perf tools: Do not set attr.exclude_guest by default (v5)

Hello,

I found perf tools set exclude_guest bit inconsistently. It used to set the bit but now the default event for perf record doesn't. So I'm wondering why we want the bit in the first place.

Actually it's not good for PMUs don't support any exclusion like AMD IBS because it disables new features after the exclude_guest due to the missing feature detection logic.

v5 changes)

* fix instruction:P failure on AMD (Ravi)
* add per-pmu exclude_guest test again (Ravi)
* add precise_max subtest to perf record shell test

v4) https://lore.kernel.org/lkml/[email protected]

* handle EOPNOTSUPP error in compatible way (Kan)
* drop --exclude-guest option in perf stat
* not to separate exclude_hv fallback
* rename to exclude_GH_default (Kan)
* drop the RFC from the subject

v3) https://lore.kernel.org/lkml/[email protected]/

* move exclude_guest fallback to the front
* fix precise_max handling on AMD
* simplify the default event for perf record

v2) https://lore.kernel.org/lkml/[email protected]/

* update the missing feature detection logic
* separate exclude_hv fallback
* add new fallback for exclude_guest

v1) https://lore.kernel.org/lkml/[email protected]/

AFAIK it doesn't matter for the most cases but perf kvm. If users need to set the bit, they can still use :H modifier. For vPMU pass- through or Apple M1, it'd add the exclude_guest during the fallback logic.

Also the kernel feature detection logic should be separated from the exclude bit tests since it depends on the PMU implementation rather than the core kernel features. So I changed it to use a software event for the detection and factor out some hw-specific checks.

The code is available at 'perf/exclude-v5' branch in
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (9):
perf tools: Add fallback for exclude_guest
perf tools: Don't set attr.exclude_guest by default perf tools: Simplify evsel__add_modifier()
perf tools: Do not set exclude_guest for precise_ip perf tools: Detect missing kernel features properly perf tools: Move x86__is_amd_cpu() to util/env.c
perf tools: Check fallback error and order
perf record: Just use "cycles:P" as the default event perf test: Add precise_max subtest to the perf record shell test

 tools/perf/arch/x86/util/Build              |   1 -
 tools/perf/arch/x86/util/env.c              |  19 -
 tools/perf/arch/x86/util/env.h              |   7 -
 tools/perf/arch/x86/util/pmu.c              |   2 +-
 tools/perf/builtin-kvm.c                    |   1 +
 tools/perf/builtin-record.c                 |   4 +-
 tools/perf/builtin-stat.c                   |  18 +-
 tools/perf/dlfilters/dlfilter-test-api-v0.c |   2 +-
 tools/perf/dlfilters/dlfilter-test-api-v2.c |   2 +-
 tools/perf/tests/attr/test-record-dummy-C0  |   2 +-
 tools/perf/tests/parse-events.c             |  30 +-
 tools/perf/tests/shell/record.sh            |  25 ++
 tools/perf/tests/shell/stat.sh              |   2 +-
 tools/perf/util/env.c                       |  23 +
 tools/perf/util/env.h                       |   4 +
 tools/perf/util/evsel.c                     | 457 +++++++++++++++-----
 tools/perf/util/evsel.h                     |   1 -
 tools/perf/util/parse-events.c              |   6 +-
 tools/perf/util/pmu.h                       |   4 +
 tools/perf/util/util.c                      |  10 +-
 tools/perf/util/util.h                      |   3 +
 21 files changed, 452 insertions(+), 171 deletions(-)
 delete mode 100644 tools/perf/arch/x86/util/env.c
 delete mode 100644 tools/perf/arch/x86/util/env.h

base-commit: ea2ead4224fd3899f6dadd4c1fc526f32ec2246c

Signature · 1 line
2.47.0.rc1.288.g06298d1525-goog