Skip to content

rust: xarray: Add a minimal abstraction for XArray

Tamir Duberstein linux-fsdevel linux-pci lkml rust-for-linux 11 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20241020-rust-xarray-bindings-bef514142968

Versions newest first

  1. v19 Latest3 patches 8 repliesApplied
  2. v183 patches 4 repliesSuperseded
  3. v173 patches 4 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v164 patches25 repliesSuperseded
v153 patches8 repliesSuperseded
v142 patches0 repliesSuperseded
v132 patches2 repliesSuperseded
v122 patches9 repliesSuperseded
v112 patches4 repliesSuperseded
v102 patches13 repliesSuperseded
v92 patches17 repliesSuperseded

Changes in v19 from the cover letter

- Rebase on v6.15-rc2.
- Link to v18: https://lore.kernel.org/r/[email protected]

Patches in v19 Applied

#Subject and filesSizeRepliesApplied
1/3rust: types: add `ForeignOwnable::PointedTo`rust/kernel/alloc/kbox.rs rust/kernel/miscdevice.rs rust/kernel/pci.rs +3 more+70 -494 replies
2/3rust: xarray: Add an abstraction for XArrayrust/bindings/bindings_helper.h rust/helpers/helpers.c rust/helpers/xarray.c +2 more+311 -00 replies
3/3MAINTAINERS: add entry for Rust XArray APIMAINTAINERS+11 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDanilo KrummrichMaíra CanalAsahi LinaAndreas HindborgAlice Ryhl
1/3A-b
2/3Inspired-by Inspired-by R-b R-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v19 thread

Cover letter [PATCH v19 0/3] rust: xarray: Add a minimal abstraction for XArray

This is a reimagining relative to earlier versions[0] by Asahi Lina and Maíra Canal.

It is needed to support rust-binder, though this version only provides enough machinery to support rnull.

---
Changes in v19:
- Rebase on v6.15-rc2.
- Link to v18: https://lore.kernel.org/r/[email protected]

Changes in v18:
- Add INVARIANT comment in XArray::new. (Danilo Krummrich)
- Replace destructuring with field access in
impl<T> From<StoreError<T>> for Error. (Danilo Krummrich)
- Use enumerations in SAFETY comments (3x). (Danilo Krummrich)
- Link to v17: https://lore.kernel.org/r/[email protected]

Changes in v17:
- Drop patch "rust: remove redundant as _ casts". (Danilo Krummrich)
- Drop trailers for shared commit from configfs series[0]. (Danilo
Krummrich)
- Avoid shadowing expressions with .cast() calls. (Danilo Krummrich)
- Link to v16: https://lore.kernel.org/r/[email protected]

Changes in v16:
- Extract prequel patch for as _ casts. (Danilo Krummrich)
- Improve doc and safety comments. (Boqun Feng)
- Pull trailers for shared commit from configfs series[0]. (Andreas Hindborg, Alice Ryhl, Fiona Behrens)
- Link to configfs series: https://lore.kernel.org/rust-for-linux/[email protected]/
- Link to v15: https://lore.kernel.org/r/[email protected]

Changes in v15:
- Rebase on v6.14-rc1.
- Add MAINTAINERS entry.
- Link to v14: https://lore.kernel.org/r/[email protected]

Changes in v14:
- Remove TODO made stale by Gary Guo's FFI type series.
- Link: https://lore.kernel.org/all/[email protected]/
- Link to v13: https://lore.kernel.org/r/[email protected]

Changes in v13:
- Replace bool::then with if. (Miguel Ojeda)
- Replace match with let + if. (Miguel Ojeda)
- Link to v12: https://lore.kernel.org/r/[email protected]

Changes in v12:
- Import core::ptr::NonNull. (Alice Ryhl)
- Introduce StoreError to allow ? to be used with Guard::store.
(Alice Ryhl)
- Replace {crate,core}::ffi::c_ulong and clarify TODO with respect to
usize. (Alice Ryhl)
- Drop T: Sync bound on impl Sync for XArray<T>. (Alice Ryhl)
- Reword Send and Sync safety comments to match the style used in
lock.rs. (Alice Ryhl and Andreas
Hindborg)
- Link to v11: https://lore.kernel.org/r/[email protected]

Changes in v11:
- Consolidate imports. (Alice Ryhl)
- Use literal 0 rather than MIN. (Alice Ryhl)
- Use bulleted list in SAFETY comment. (Alice Ryhl)
- Document (un)locking behavior of Guard::store. (Alice Ryhl)
- Document Normal API behavior WRT XA_ZERO_ENTRY. (Alice Ryhl)
- Rewrite unsafe impl Sync SAFETY comment. (Andreas Hindborg)
- Link to v10: https://lore.kernel.org/r/[email protected]

Changes in v10:
- Guard::get takes &self instead of &mut self. (Andreas Hindborg)
- Guard is !Send. (Boqun Feng)
- Add Inspired-by tags. (Maíra Canal and Asahi Lina)
- Rebase on linux-next, use NotThreadSafe. (Alice Ryhl)
- Link to v9: https://lore.kernel.org/r/[email protected]

---
Tamir Duberstein (3):
rust: types: add ForeignOwnable::PointedTo
rust: xarray: Add an abstraction for XArray
MAINTAINERS: add entry for Rust XArray API

 MAINTAINERS                     |  11 ++
 rust/bindings/bindings_helper.h |   6 +
 rust/helpers/helpers.c          |   1 +
 rust/helpers/xarray.c           |  28 ++++
 rust/kernel/alloc/kbox.rs       |  38 +++---
 rust/kernel/lib.rs              |   1 +
 rust/kernel/miscdevice.rs       |  10 +-
 rust/kernel/pci.rs              |   2 +-
 rust/kernel/platform.rs         |   2 +-
 rust/kernel/sync/arc.rs         |  21 +--
 rust/kernel/types.rs            |  46 ++++---
 rust/kernel/xarray.rs           | 275 ++++++++++++++++++++++++++++++++++++++++
 12 files changed, 392 insertions(+), 49 deletions(-)

---
base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472
change-id: 20241020-rust-xarray-bindings-bef514142968

Best regards,

Signature · 1 line
Tamir Duberstein <[email protected]>