Skip to content

Add support for nuvoton ma35d1 keypad controller

Ming-Jen linux-arm-kernel linux-devicetree linux-input lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 1 replyIn review
  2. v52 patches 3 repliesSuperseded
  3. v42 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 patches5 repliesSuperseded
v22 patches3 repliesSuperseded
v12 patches14 repliesSuperseded

Changes in v6 from the cover letter

- Update nuvoton,ma35d1-keypad.yaml
- Modify 'compatible' to make filename matching compatible.
- Update ma35d1_keypad.c
- Modify 'compatible' to match the name in the .yaml file.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: input: Add Nuvoton MA35D1 keypadDocumentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml+82 -01 reply
2/2input: keypad: add new keypad driver for MA35D1drivers/input/keyboard/Kconfig drivers/input/keyboard/Makefile drivers/input/keyboard/ma35d1_keypad.c+398 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] Add support for nuvoton ma35d1 keypad controller

From: Ming-jen Chen <[email protected]>

v6:
- Update nuvoton,ma35d1-keypad.yaml
- Modify 'compatible' to make filename matching compatible.
- Update ma35d1_keypad.c
- Modify 'compatible' to match the name in the .yaml file.

v5:
- Update nuvoton,ma35d1-keypad.yaml
- Reorders the items in the properties and required blocks to ensure their order and items are consistent.
v4:
- Update nuvoton,ma35d1-keypad.yaml
- Kept the same order of properties as in the required block.
- Changed register addresses to lowercase.
v3:
- Update nuvoton,ma35d1-keypad.yaml
- Removed vendor-specific properties and replaced them with common properties
- Update ma35d1_keypad.c
- Modified the driver to reflect changes in the YAML properties
v2:
- Update nuvoton,ma35d1-keypad.yaml
- Fixed warnings and errors generated by running checkpatch.pl
- Removed the previous version's properties and rewrote the properties in the Device Tree schema.
- Renamed the Device Tree binding file to nuvoton,ma35d1-keypad.yaml
- Update Kconfig
- Added COMPILE_TEST to the depends on line in the Kconfig
- Update ma35d1_keypad.c
- Refactored error handling within the probe function.
- Fixed the mixed use of devm and non-devm resource management.
- Corrected alignment issues in the code.
- Updated suspend and resume handling methods.
- Fixed variable naming to remove camel casing.
- Used for_each_set_bit() to check key states.
- Modified the code to align with updates in the device tree binding

Ming-jen Chen (2):
dt-bindings: input: Add Nuvoton MA35D1 keypad
input: keypad: add new keypad driver for MA35D1

 .../bindings/input/nuvoton,ma35d1-keypad.yaml |  82 ++++
 drivers/input/keyboard/Kconfig                |  10 +
 drivers/input/keyboard/Makefile               |   1 +
 drivers/input/keyboard/ma35d1_keypad.c        | 387 ++++++++++++++++++
 4 files changed, 480 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
 create mode 100644 drivers/input/keyboard/ma35d1_keypad.c
Signature · 1 line
2.25.1