Skip to content

Add Intel Touch Host Controller drivers

Even Xu linux-doc linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest22 patches 11 repliesIn review
  2. v322 patches 8 repliesSuperseded
  3. v222 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v122 patches8 repliesSuperseded

Changes in v4 from the cover letter

- Minor fix in documents
- Typo fixes in patch 6 & patch 7 commit descriptions

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22HID: THC: Add documentationDocumentation/hid/index.rst Documentation/hid/intel-thc-hid.rst+569 -05 replies
2/22HID: intel-thc-hid: Add basic THC driver skeletonMAINTAINERS drivers/hid/Kconfig drivers/hid/Makefile +4 more+285 -00 replies
3/22HID: intel-thc-hid: intel-thc: Add THC registers definitiondrivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+639 -00 replies
4/22HID: intel-thc-hid: intel-thc: Add THC PIO operation APIsdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+292 -00 replies
5/22HID: intel-thc-hid: intel-thc: Add APIs for interruptdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+245 -00 replies
6/22HID: intel-thc-hid: intel-thc: Add THC DMA interfacesdrivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h +2 more+1142 -00 replies
7/22HID: intel-thc-hid: intel-thc: Add THC LTR interfacesdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+138 -00 replies
8/22HID: intel-thc-hid: intel-thc: Add THC interrupt handlerdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h+286 -00 replies
9/22HID: intel-thc-hid: intel-thc: Add THC SPI config interfacesdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+288 -00 replies
10/22HID: intel-thc-hid: intel-thc: Add THC I2C config interfacesdrivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h+417 -00 replies
11/22HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver skeletondrivers/hid/intel-thc-hid/Kconfig drivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c +1 more+362 -00 replies
12/22HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver hid layerdrivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c +2 more+205 -00 replies
13/22HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI ACPI interfacesdrivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h+243 -00 replies
14/22HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementationdrivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c +3 more+609 -10 replies
15/22HID: intel-thc-hid: intel-quickspi: Complete THC QuickSPI driverdrivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.c+268 -00 replies
16/22HID: intel-thc-hid: intel-quickspi: Add PM implementationdrivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c+262 -00 replies
17/22HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver skeletondrivers/hid/intel-thc-hid/Kconfig drivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c +1 more+332 -00 replies
18/22HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver hid layerdrivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c +2 more+212 -00 replies
19/22HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfacesdrivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h+297 -00 replies
20/22HID: intel-thc-hid: intel-quicki2c: Add HIDI2C protocol implementationdrivers/hid/intel-thc-hid/Makefile drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c +3 more+313 -10 replies
21/22HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driverdrivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.c +1 more+307 -00 replies
22/22HID: intel-thc-hid: intel-quicki2c: Add PM implementationdrivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c+249 -00 replies

Reviews trailers per patch

All 22 patches have a Reviewed-by or Acked-by.

PatchSrinivas PandruvadaBagas SanjayaMark PearsonRui ZhangAaron Ma
1/22R-b R-b R-b T-b
2/22R-b T-b R-b T-b
3/22R-b T-b R-b T-b
4/22R-b T-b R-b T-b
5/22R-b T-b R-b T-b
6/22R-b T-b R-b T-b
7/22R-b T-b R-b T-b
8/22R-b T-b R-b T-b
9/22R-b T-b R-b T-b
10/22R-b T-b R-b T-b
11/22R-b T-b R-b T-b
12/22R-b T-b R-b T-b
13/22R-b T-b R-b T-b
14/22R-b T-b R-b T-b
15/22R-b T-b R-b T-b
16/22R-b T-b R-b T-b
17/22R-b T-b R-b T-b
18/22R-b T-b R-b T-b
19/22R-b T-b R-b T-b
20/22R-b T-b R-b T-b
21/22R-b T-b R-b T-b
22/22R-b T-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/22] Add Intel Touch Host Controller drivers

Intel Touch Host Controller (THC) is a new high performance input IP which can benefit HID device's data transaction, such as touch screen, touch pad, stylus.

THC IP now evoluates to V4, it can support 3 different modes: IPTS, HIDSPI and HIDI2C. Here are upgrade history:
- THC v1, for TGL/LKF, supports intel private IPTS (Intel Precise Touch and Stylus) protocol ( IPTS mode)
- THC v2, for ADL, adds industrial standard HID over SPI protocol support (HIDSPI mode)
- THC v3, for MTL, enhances HID over SPI mode
- THC v4, for LNL, adds inudstrial standard HID over I2C protocol support (HIDI2C mode)

Linux Surface community (https://github.com/linux-surface) already implemented IPTS mode. These patch series provides THC HIDSPI mode and THC HIDI2C mode support on Linux.

These patch series includes:
1. Document for THC hardware and software introduction.
2. Intel THC Hardware layer driver which provides control interfaces for protocol layer.
3. Intel QuickSPI (R) driver working as a HIDSPI device driver which implements HID over SPI protocol and flow.
4. Intel QuickI2C (R) driver working as a HIDI2C device driver which implements HID over I2C protocol and flow.

Change logs:
v4:
- Minor fix in documents
- Typo fixes in patch 6 & patch 7 commit descriptions

v3:
- Change tables in documents from literal block to table format
- Change symbol namespace to string literal according to patch:
commit cdd30ebb1b9f ("module: Convert symbol namespace to string literal")
- Refine Kconfig description
- Enhance Quickspi and Quicki2c driver by clearing THC hardware internal state before doing initialization to avoid BIOS impacts.
- A fix in Quicki2c driver when does set_report

v2:
- Fix document format issues
- Add THC device IDs for Intel Panther Lake (PTL) platform

Even Xu (13):
HID: THC: Add documentation
HID: intel-thc-hid: intel-thc: Add THC DMA interfaces
HID: intel-thc-hid: intel-thc: Add THC I2C config interfaces
HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver hid layer
HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI ACPI interfaces
HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation
HID: intel-thc-hid: intel-quickspi: Add PM implementation
HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver skeleton
HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver hid layer
HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfaces
HID: intel-thc-hid: intel-quicki2c: Add HIDI2C protocol implementation
HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver
HID: intel-thc-hid: intel-quicki2c: Add PM implementation

Xinpeng Sun (9):
HID: intel-thc-hid: Add basic THC driver skeleton
HID: intel-thc-hid: intel-thc: Add THC registers definition
HID: intel-thc-hid: intel-thc: Add THC PIO operation APIs
HID: intel-thc-hid: intel-thc: Add APIs for interrupt
HID: intel-thc-hid: intel-thc: Add THC LTR interfaces
HID: intel-thc-hid: intel-thc: Add THC interrupt handler
HID: intel-thc-hid: intel-thc: Add THC SPI config interfaces
HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver skeleton
HID: intel-thc-hid: intel-quickspi: Complete THC QuickSPI driver

 Documentation/hid/index.rst                   |    1 +
 Documentation/hid/intel-thc-hid.rst           |  568 ++++++
 MAINTAINERS                                   |    6 +
 drivers/hid/Kconfig                           |    2 +
 drivers/hid/Makefile                          |    2 +
 drivers/hid/intel-thc-hid/Kconfig             |   42 +
 drivers/hid/intel-thc-hid/Makefile            |   22 +
 .../intel-quicki2c/pci-quicki2c.c             |  966 ++++++++++
 .../intel-quicki2c/quicki2c-dev.h             |  186 ++
 .../intel-quicki2c/quicki2c-hid.c             |  166 ++
 .../intel-quicki2c/quicki2c-hid.h             |   14 +
 .../intel-quicki2c/quicki2c-protocol.c        |  224 +++
 .../intel-quicki2c/quicki2c-protocol.h        |   20 +
 .../intel-quickspi/pci-quickspi.c             |  987 +++++++++++
 .../intel-quickspi/quickspi-dev.h             |  172 ++
 .../intel-quickspi/quickspi-hid.c             |  165 ++
 .../intel-quickspi/quickspi-hid.h             |   14 +
 .../intel-quickspi/quickspi-protocol.c        |  414 +++++
 .../intel-quickspi/quickspi-protocol.h        |   25 +
 .../intel-thc-hid/intel-thc/intel-thc-dev.c   | 1578 +++++++++++++++++
 .../intel-thc-hid/intel-thc/intel-thc-dev.h   |  116 ++
 .../intel-thc-hid/intel-thc/intel-thc-dma.c   |  969 ++++++++++
 .../intel-thc-hid/intel-thc/intel-thc-dma.h   |  146 ++
 .../intel-thc-hid/intel-thc/intel-thc-hw.h    |  881 +++++++++
 include/linux/hid-over-i2c.h                  |  117 ++
 include/linux/hid-over-spi.h                  |  155 ++
 26 files changed, 7958 insertions(+)
 create mode 100644 Documentation/hid/intel-thc-hid.rst
 create mode 100644 drivers/hid/intel-thc-hid/Kconfig
 create mode 100644 drivers/hid/intel-thc-hid/Makefile
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
 create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.h
 create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h
 create mode 100644 include/linux/hid-over-i2c.h
 create mode 100644 include/linux/hid-over-spi.h
Signature · 1 line
2.40.1