gdbstub: Allow late attachment
Status from this message: Queued to gdbstub/next, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 3 repliesApplied
- v58 patches 0 repliesSuperseded
- v49 patches 3 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 8 patches | 6 replies | Superseded | |
| v2 | 8 patches | 0 replies | Superseded | |
| v1 | 8 patches | 12 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | gdbstub: Allow the %d placeholder in the socket pathgdbstub/ | +10 | 0 replies | |
| 2/8 | gdbstub: Try unlinking the unix socket before bindinggdbstub/ stubs/ stubs/ +1 more | +16 | 1 reply | |
| 3/8 | user: Introduce user/signal.hbsd-user/ bsd-user/ include/ +3 more | +26 | 0 replies | |
| 4/8 | user: Introduce host_interrupt_signalbsd-user/ include/ linux-user/ | +34 | 0 replies | |
| 5/8 | osdep: Introduce qemu_kill_thread()include/ util/ | +24 | 0 replies | |
| 6/8 | gdbstub: Allow late attachmentbsd-user/ gdbstub/ linux-user/ | +103 | 1 reply | |
| 7/8 | docs/user: Document the %d placeholder and suspend=n QEMU_GDB featuresdocs/ | +13 | 0 replies | |
| 8/8 | tests/tcg: Add late gdbstub attach testtests/ tests/ tests/ +1 more | +90 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Warner Losh | Alex Bennée |
|---|---|---|---|
| 1/8 | R-b | R-b | |
| 2/8 | R-b | ||
| 3/8 | R-b | R-b | |
| 4/8 | R-b | ||
| 5/8 | R-b | R-b | |
| 6/8 | R-b | ||
| 7/8 | R-b | ||
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/8] gdbstub: Allow late attachment
Based-on: <[email protected]>
v5: https://lore.kernel.org/qemu-devel/[email protected]/
v5 -> v6: Rebase on top of the Alex's changes.
v4: https://lore.kernel.org/qemu-devel/[email protected]/
v4 -> v5: Fix the qemu-user-only build by adding qemu-sockets.c to it.
Drop the qapi_bool_parse() changes (Daniel).
v3: https://lore.kernel.org/qemu-devel/[email protected]/
v3 -> v4: Rebase.
Add missing "\n"s to error messages.
Use unix_listen() (Alex).
Use qapi_bool_parse() and patch it to accept NULL (Alex). Remove a leftover include (Alex).
Rename port_or_path to path, set it to NULL after freeing (Alex).
v2: https://lore.kernel.org/qemu-devel/[email protected]/
v2 -> v3: Rebase.
Patches that need review:
- [PATCH 2/8] gdbstub: Try unlinking the unix socket before binding
- [PATCH 4/8] user: Introduce host_interrupt_signal # linux part
- [PATCH 6/8] gdbstub: Allow late attachment
- [PATCH 7/8] docs/user: Document the %d placeholder and suspend=n QEMU_GDB features
- [PATCH 8/8] tests/tcg: Add late gdbstub attach test
v1: https://lore.kernel.org/qemu-devel/[email protected]/
v1 -> v2: Rebase, fix conflicts with the QEMU_RTSIG_MAP patch.
Use qemu_get_thread_id() for %d (Helge, Richard, Warner). Add R-bs, except for the Richard's one on 4/8, since conflict resolution caused a noticeable change.
Hi,
This series adds the ability to attach GDB to a running qemu-user instance. This is useful for debugging multi-process apps.
Patches 1 and 2 implement a small related feature: the ability to create individual UNIX sockets for each child process.
Patches 3-5 add the required infrastructure. In particular, we need to reserve a host signal for waking up threads, as discussed in [1]. By the way, the problem with atomicity of checking for pending signals and invoking syscalls that I'm describing in that thread seems to have already been solved by the safe_syscall infrastructure, so the changes are fairly simple.
Patch 6 is the implementation, patch 7 is a documentation update, patch 8 is a test. I tested this series on Linux and only compile-tested on the BSDs.
If this series is accepted, I will rebase the all-stop series on top of it.
Best regards,
Ilya
Ilya Leoshkevich (8):
gdbstub: Allow the %d placeholder in the socket path
gdbstub: Try unlinking the unix socket before binding
user: Introduce user/signal.h
user: Introduce host_interrupt_signal
osdep: Introduce qemu_kill_thread()
gdbstub: Allow late attachment
docs/user: Document the %d placeholder and suspend=n QEMU_GDB features tests/tcg: Add late gdbstub attach test
bsd-user/main.c | 1 - bsd-user/signal-common.h | 1 - bsd-user/signal.c | 13 ++ docs/user/main.rst | 16 ++- gdbstub/user.c | 150 ++++++++++++++++----- include/qemu/osdep.h | 9 ++ include/user/signal.h | 25 ++++ linux-user/main.c | 1 - linux-user/signal-common.h | 1 - linux-user/signal.c | 26 +++- linux-user/syscall.c | 1 + stubs/meson.build | 2 + stubs/monitor-fd.c | 9 ++ tests/guest-debug/run-test.py | 15 ++- tests/tcg/multiarch/Makefile.target | 9 +- tests/tcg/multiarch/gdbstub/late-attach.py | 28 ++++ tests/tcg/multiarch/late-attach.c | 41 ++++++ util/meson.build | 2 + util/oslib-posix.c | 15 +++ 19 files changed, 314 insertions(+), 51 deletions(-) create mode 100644 include/user/signal.h create mode 100644 stubs/monitor-fd.c create mode 100644 tests/tcg/multiarch/gdbstub/late-attach.py create mode 100644 tests/tcg/multiarch/late-attach.c
Signature · 1 line
2.47.1