Skip to content

memcg-v1: fully deprecate charge moving

Shakeel Butt cgroups linux-doc linux-fsdevel linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 29 repliesIn review 5 of 6 applied

Changes since RFC from the cover letter

- Writing 0 to memory.move_charge_at_immigrate is allowed.
- Remove the memcg move locking in separate patches.

Patches in v1 5 of 6 applied

#Subject and filesSizeRepliesApplied
1/6memcg-v1: fully deprecate move_charge_at_immigrateDocumentation/admin-guide/cgroup-v1/memory.rst mm/memcontrol-v1.c+5 -912 repliesApplied
2/6memcg-v1: remove charge move codeinclude/linux/memcontrol.h mm/memcontrol-v1.c mm/memcontrol-v1.h +1 more+0 -8823 repliesApplied
3/6memcg-v1: no need for memcg locking for dirty trackingfs/buffer.c mm/page-writeback.c+3 -184 repliesApplied
4/6memcg-v1: no need for memcg locking for writeback trackingmm/page-writeback.c+0 -43 repliesApplied
5/6memcg-v1: no need for memcg locking for MGLRUmm/vmscan.c+0 -1111 replies
6/6memcg-v1: remove memcg move locking codeinclude/linux/memcontrol.h mm/filemap.c mm/memcontrol-v1.c +2 more+0 -1435 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRoman GushchinMichal HockoJohannes Weiner
1/6R-b A-b A-b
2/6R-b A-b A-b
3/6R-b A-b A-b
4/6R-b A-b A-b
5/6R-b
6/6R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/6] memcg-v1: fully deprecate charge moving

The memcg v1's charge moving feature has been deprecated for almost 2 years and the kernel warns if someone try to use it. This warning has been backported to all stable kernel and there have not been any report of the warning or the request to support this feature anymore. Let's proceed to fully deprecate this feature.

Changes since RFC:
- Writing 0 to memory.move_charge_at_immigrate is allowed.
- Remove the memcg move locking in separate patches.

Shakeel Butt (6):
memcg-v1: fully deprecate move_charge_at_immigrate
memcg-v1: remove charge move code
memcg-v1: no need for memcg locking for dirty tracking
memcg-v1: no need for memcg locking for writeback tracking
memcg-v1: no need for memcg locking for MGLRU
memcg-v1: remove memcg move locking code

 .../admin-guide/cgroup-v1/memory.rst          |  82 +-
 fs/buffer.c                                   |   5 -
 include/linux/memcontrol.h                    |  59 --
 mm/filemap.c                                  |   1 -
 mm/memcontrol-v1.c                            | 958 +-----------------
 mm/memcontrol-v1.h                            |   6 -
 mm/memcontrol.c                               |  14 -
 mm/page-writeback.c                           |  20 +-
 mm/rmap.c                                     |   1 -
 mm/vmscan.c                                   |  11 -
 10 files changed, 8 insertions(+), 1149 deletions(-)
Signature · 1 line
2.43.5