Skip to content

Mypy and pylint build support

Ian Rogers linux-perf-users lkml 2 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesApplied
  2. v16 patches 12 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6tools/build: Don't pass test log files to linkertools/build/Makefile.build+5 -10 replies
2/6perf build: Rename TEST_LOGS to SHELL_TEST_LOGStools/perf/Build tools/perf/Makefile.perf tools/perf/arch/x86/Build +4 more+19 -190 replies
3/6perf build: Add mypy build teststools/perf/Build tools/perf/Makefile.perf tools/perf/pmu-events/Build +3 more+71 -20 replies
4/6perf build: Add pylint build teststools/perf/Build tools/perf/Makefile.perf tools/perf/pmu-events/Build +3 more+69 -20 replies
5/6perf test: Address attr.py mypy errortools/perf/tests/shell/lib/attr.py+1 -70 replies
6/6perf python: Fix setup.py mypy errorstools/perf/util/setup.py+8 -20 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJames Clark
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] Mypy and pylint build support

Support building perf checking the python code with mypy and/or pylint. Currently there are too many errors to make this a default.

Shellcheck generates no output on success, so linking shellcheck files doesn't cause ld to fail. Mypy and pylint generate output that will break ld so change the Makefile.build to ignore test log files.

Address some initial mypy errors.

v2: Rebase. Add James Clark's reviewed-by tags. Add example mypy and
pylint error output.

Ian Rogers (6):
tools/build: Don't pass test log files to linker perf build: Rename TEST_LOGS to SHELL_TEST_LOGS perf build: Add mypy build tests
perf build: Add pylint build tests
perf test: Address attr.py mypy error perf python: Fix setup.py mypy errors

 tools/build/Makefile.build         |  6 +++++-
 tools/perf/Build                   | 32 +++++++++++++++++++++++++++---
 tools/perf/Makefile.perf           | 14 +++++++++++--
 tools/perf/arch/x86/Build          |  6 +++---
 tools/perf/arch/x86/tests/Build    |  6 +++---
 tools/perf/pmu-events/Build        | 25 ++++++++++++++++++++++-
 tools/perf/scripts/Build           | 26 ++++++++++++++++++++++++
 tools/perf/tests/Build             | 32 +++++++++++++++++++++++++++---
 tools/perf/tests/shell/lib/attr.py |  8 +-------
 tools/perf/trace/beauty/Build      |  6 +++---
 tools/perf/util/Build              | 31 ++++++++++++++++++++++++++---
 tools/perf/util/setup.py           | 10 ++++++++--
 12 files changed, 171 insertions(+), 31 deletions(-)
Signature · 1 line
2.49.0.rc0.332.g42c0ae87b1-goog