Skip to content

bpf, x64: Introduce two tailcall enhancements

Leon Hwang bpf 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review 1 of 2 applied
  2. v22 patches 0 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

* Add Yonghong's ACK.

Patches in v3 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2bpf, x64: Propagate tailcall info only for subprogsarch/x86/net/bpf_jit_comp.c+2 -14 repliesApplied
2/2bpf, verifier: Check trampoline target is tail_call_reachable subproginclude/linux/bpf.h kernel/bpf/verifier.c+4 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYonghong Song
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/2] bpf, x64: Introduce two tailcall enhancements

This patch set introduces two enhancements aimed at improving tailcall handling in the x64 JIT:

1. Tailcall info is propagated only for subprogs.
2. Tailcall info is propagated through the trampoline only when the target is a subprog and it is tail_call_reachable.

Changes:
v2 -> v3:
* Add Yonghong's ACK.

v1 -> v2:
* Address comment from Alexei:
* Rather live with tail call inefficiency than abuse insns fields further.

Leon Hwang (2):
bpf, x64: Propagate tailcall info only for subprogs
bpf, verifier: Check trampoline target is tail_call_reachable subprog

 arch/x86/net/bpf_jit_comp.c | 3 ++-
 include/linux/bpf.h         | 1 +
 kernel/bpf/verifier.c       | 4 +++-
 3 files changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.44.0