Skip to content

x86: Address Space Isolation FPU preparations

Alejandro Vallejo xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 16 repliesIn review
  2. v213 patches 23 repliesSuperseded
  3. v114 patches 21 repliesSuperseded

Changes in v3 from the cover letter

* Evaluated v argument in UNMAP operation (see patch 1)
* Fixed bug on (de)compressing xstates by not unmapping them on early return.
* Constified more when converting (f)xrstor and (f)xsave

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12x86/xstate: Create map/unmap primitives for xsave areasxen/arch/x86/include/asm/xstate.h+42 -02 replies
2/12x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt()xen/arch/x86/hvm/hvm.c+4 -40 replies
3/12x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu()xen/arch/x86/i387.c+13 -50 replies
4/12x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv()xen/arch/x86/xstate.c+10 -20 replies
5/12x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu()xen/arch/x86/hvm/emulate.c+10 -20 replies
6/12x86/domctl: Map/unmap xsave area in arch_get_info_guest()xen/arch/x86/domctl.c+5 -40 replies
7/12x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states()xen/arch/x86/xstate.c+10 -41 reply
8/12x86/emulator: Refactor FXSAVE_AREA to use wrappersxen/arch/x86/x86_emulate/blk.c+10 -16 replies
9/12x86/mpx: Map/unmap xsave area in in read_bndcfgu()xen/arch/x86/xstate.c+9 -32 replies
10/12x86/fpu: Pass explicit xsave areas to fpu_(f)xsave()xen/arch/x86/i387.c xen/arch/x86/include/asm/xstate.h xen/arch/x86/xstate.c+12 -92 replies
11/12x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor()xen/arch/x86/i387.c xen/arch/x86/include/asm/xstate.h xen/arch/x86/xstate.c+23 -153 replies
12/12x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstatexen/arch/x86/i387.c xen/arch/x86/include/asm/xstate.h xen/arch/x86/xstate.c+9 -70 replies

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/12A-b
2/12A-b
3/12A-b
4/12A-b
5/12A-b
6/12A-b
7/12R-b
8/12A-b
9/12
10/12A-b
11/12A-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/12] x86: Address Space Isolation FPU preparations

See original cover letter in v1

v2: https://lore.kernel.org/xen-devel/[email protected]/
v2->v3:
* Evaluated v argument in UNMAP operation (see patch 1)
* Fixed bug on (de)compressing xstates by not unmapping them on early return.
* Constified more when converting (f)xrstor and (f)xsave

v1: https://lore.kernel.org/xen-devel/[email protected]/
v1->v2:
* Turned v1/patch1 into an assert removal
* Dropped v1/patch11: "x86/mpx: Adjust read_bndcfgu() to clean after itself"
* Other minor changes out of feedback. Explained in each patch.

Alejandro Vallejo (12):
x86/xstate: Create map/unmap primitives for xsave areas x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt() x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu() x86/xstate: Map/unmap xsave area in xstate_set_init() and
handle_setbv()
x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu() x86/domctl: Map/unmap xsave area in arch_get_info_guest() x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states() x86/emulator: Refactor FXSAVE_AREA to use wrappers x86/mpx: Map/unmap xsave area in in read_bndcfgu() x86/fpu: Pass explicit xsave areas to fpu_(f)xsave() x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor() x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit
xstate

 xen/arch/x86/domctl.c             |  9 ++--
 xen/arch/x86/hvm/emulate.c        | 12 +++++-
 xen/arch/x86/hvm/hvm.c            |  8 ++--
 xen/arch/x86/i387.c               | 69 ++++++++++++++++++++-----------
 xen/arch/x86/include/asm/xstate.h | 51 +++++++++++++++++++++--
 xen/arch/x86/x86_emulate/blk.c    | 11 ++++-
 xen/arch/x86/xstate.c             | 53 +++++++++++++++++-------
 7 files changed, 157 insertions(+), 56 deletions(-)
Signature · 1 line
2.47.1