Skip to content

Issue non-NCQ command via EH when NCQ commands in-flight

Niklas Cassel linux-ide linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ata: libata: Introduce new helper ata_qc_complete_success()drivers/ata/libata-core.c include/linux/libata.h+60 -461 reply
2/2ata: libata: Issue non-NCQ command via EH when NCQ commands in-flightdrivers/ata/libata-core.c drivers/ata/libata-eh.c drivers/ata/libata-scsi.c +2 more+237 -163 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Issue non-NCQ command via EH when NCQ commands in-flight

Hello all,

There is a problem when an application is continuously submitting NCQ commands (e.g. fio with a queue depth greater than 1), this can completely starve out another application that is sending a non-NCQ command (because the non-NCQ command will be deferred forever).

Xingui Yang reported this problem here:
https://lore.kernel.org/linux-block/[email protected]/

This series addresses the reported problem.

Please test!

Kind regards,
Niklas

Niklas Cassel (2):
ata: libata: Introduce new helper ata_qc_complete_success()
ata: libata: Issue non-NCQ command via EH when NCQ commands in-flight

 drivers/ata/libata-core.c | 274 ++++++++++++++++++++++++++++++--------
 drivers/ata/libata-eh.c   |  60 ++++++++-
 drivers/ata/libata-scsi.c |  16 ++-
 drivers/ata/libata.h      |   1 +
 include/linux/libata.h    |   8 +-
 5 files changed, 297 insertions(+), 62 deletions(-)
Signature · 1 line
2.47.0