test/intel/xe_sysfs: Restore sysfs params correctly
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest4 patches 6 repliesIn review
- v94 patches 1 replySuperseded
- v84 patches 4 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 4 patches | 5 replies | Superseded | |
| v6 | 3 patches | 0 replies | Superseded | |
| v5 | 3 patches | 2 replies | Superseded | |
| v4 | 2 patches | 3 replies | Superseded | |
| v3 | 2 patches | 3 replies | Superseded | |
| v2 | 2 patches | 4 replies | Superseded |
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lib/igt_sysfs: Add engine list helperslib/ lib/ | +64 | 0 replies | |
| 2/4 | tests/intel/xe_sysfs*: Restore values on test failuretests/ tests/ | +110 | 0 replies | |
| 3/4 | tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeouttests/ | +17 | 3 replies | |
| 4/4 | tests/intel/xe_sysfs_scheduler: Assert sysfs params are restoredtests/ | +79 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Kamil Konieczny | Tejas Upadhyay |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 0/4] test/intel/xe_sysfs: Restore sysfs params correctly
The xe_sysfs_timeslice_duration, xe_sysfs_preempt_timeout, and xe_sysfs_scheduler tests do not correctly restore modified sysfs params on test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore preempt_timeout_us.
Finally, while xe_sysfs_scheduler does attempt to restore all modified sysfs params at the end of the tests, no guarantee is made that the restorations are successful.
Repair these issues.
v3: Fix several formatting issues (Kamil)
v4: Do not compare possibly unassigned variable (Kamil)
Whitespace and commit name fixes (Kamil)
v5: Add new helper funciton, igt_sysfs_get_next_engine
Fix igt_sysfs_scanf/printf usage in tests (Kamil)
v6: Replace helper function igt_sysfs_get_next_engine with new helper
functions that return and destroy engine lists (Kamil)
v7: Also fix xe_sysfs_scheduler
v8: Update igt_sysfs_get_engine_list to no longer require reporting
size (Kamil)
Remove assertion for some sysfs writes to succeed, as we only require that the end result is correct.
v9: Store engine lists (Kamil)
v10: Minor formatting fix
Jonathan Cavitt (4):
lib/igt_sysfs: Add engine list helpers tests/intel/xe_sysfs*: Restore values on test failure tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored
lib/igt_sysfs.c | 61 ++++++++++++++++ lib/igt_sysfs.h | 3 + tests/intel/xe_sysfs_preempt_timeout.c | 65 ++++++++++++++--- tests/intel/xe_sysfs_scheduler.c | 89 ++++++++++++++++++++--- tests/intel/xe_sysfs_timeslice_duration.c | 81 ++++++++++++++++++--- 5 files changed, 269 insertions(+), 30 deletions(-)
Signature · 1 line
2.43.0