Skip to content

staging: gpib: Patch set for gpib staging drivers

Dave Penkler linux-staging lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesIn review
  2. v211 patches 4 repliesSuperseded
  3. v19 patches 7 repliesSuperseded

Changes in v3 from the cover letter

Incorporate the lpvo patch 5 into patch 2
Remove commented out console messages in patch 4
Add a separate patch for module description -> Patch 5
Add a separate patch for mutex comment -> Patch 6
Change "spelling error" to "typo" in commit message in patch 8 (was 7) Clarfiy commit message in patch 11 (was patch 10)
Add a fixes tag to patch 12 (was 11)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12staging: gpib: Fix buffer overflow in ni_usb_initdrivers/staging/gpib/ni_usb/ni_usb_gpib.c+1 -10 replies
2/12staging: gpib: Replace custom debug with dev_dbgdrivers/staging/gpib/Kconfig drivers/staging/gpib/Makefile drivers/staging/gpib/cb7210/cb7210.c +11 more+147 -1580 replies
3/12staging: gpib: Update messaging and usb_device refs in ni_usbdrivers/staging/gpib/ni_usb/ni_usb_gpib.c+204 -1720 replies
4/12staging: gpib: Update messaging and usb_device refs in agilent_usbdrivers/staging/gpib/agilent_82357a/agilent_82357a.c+144 -1130 replies
5/12staging: gpib: Fix MODULES_DESCRIPTIONdrivers/staging/gpib/agilent_82357a/agilent_82357a.c+1 -10 replies
6/12staging: gpib: Add comment for mutex definedrivers/staging/gpib/agilent_82357a/agilent_82357a.c+1 -10 replies
7/12staging: gpib: Use dev_xxx for messagingdrivers/staging/gpib/agilent_82350b/agilent_82350b.c+42 -280 replies
8/12staging: gpib: Fix Kconfigdrivers/staging/gpib/Kconfig+2 -20 replies
9/12staging: gpib: Remove unneeded lookup tabledrivers/staging/gpib/gpio/gpib_bitbang.c+0 -330 replies
10/12staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tablesdrivers/staging/gpib/gpio/gpib_bitbang.c+0 -40 replies
11/12staging: gpib: Re-order the lookup tablesdrivers/staging/gpib/gpio/gpib_bitbang.c+3 -30 replies
12/12staging: gpib: Correct check for max secondary addressdrivers/staging/gpib/common/gpib_os.c drivers/staging/gpib/common/iblib.c drivers/staging/gpib/common/ibsys.h+7 -60 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers

Patch 1 is a bug fix
Patches 2-4 replace custom debug with dev_dbg as well as
using dev_xxx for pr_xxx where feasible.
Patch 5 Fixes the agilent_usb module description Patch 6 Addresses a checkpatch CHECK for mutex comment Patch 7 Changes dev_xxx for pr_xxx in the agilent PCI driver Patch 8 Corrects some errors in Kconfig
Patch 9-11 are code cleanups
Patch 12 corrects some GPIB behaviour

Changes in v3
Incorporate the lpvo patch 5 into patch 2
Remove commented out console messages in patch 4
Add a separate patch for module description -> Patch 5
Add a separate patch for mutex comment -> Patch 6
Change "spelling error" to "typo" in commit message in patch 8 (was 7) Clarfiy commit message in patch 11 (was patch 10)
Add a fixes tag to patch 12 (was 11)

Changes in v2
Add staging: gpib: prefix to subject lines
-Patch 1 Use kmalloc_array, remove blanks in commit message and add Fixes tag -Patch 3 Delete commented out code
-Patch 7 Fix Fixes tag
-Patch 8 Split into 3 patches 8,9 & 10
-Patch 9 -> 11 Clarify commit message, delete blank line and add defines
for max primary and secondary addresses.

Dave Penkler (12):
staging: gpib: Fix buffer overflow in ni_usb_init
staging: gpib: Replace custom debug with dev_dbg
staging: gpib: Update messaging and usb_device refs in ni_usb
staging: gpib: Update messaging and usb_device refs in agilent_usb
staging: gpib: Fix MODULES_DESCRIPTION
staging: gpib: Add comment for mutex define
staging: gpib: Use dev_xxx for messaging
staging: gpib: Fix Kconfig
staging: gpib: Remove unneeded lookup table
staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tables
staging: gpib: Re-order the lookup tables
staging: gpib: Correct check for max secondary address

 drivers/staging/gpib/Kconfig                  |  14 +-
 drivers/staging/gpib/Makefile                 |   1 -
 .../gpib/agilent_82350b/agilent_82350b.c      |  70 ++--
 .../gpib/agilent_82357a/agilent_82357a.c      | 261 ++++++------
 drivers/staging/gpib/cb7210/cb7210.c          |   2 +-
 drivers/staging/gpib/common/gpib_os.c         | 142 +++----
 drivers/staging/gpib/common/iblib.c           |  22 +-
 drivers/staging/gpib/common/ibsys.h           |   7 +-
 drivers/staging/gpib/eastwood/fluke_gpib.c    |   2 +-
 drivers/staging/gpib/fmh_gpib/fmh_gpib.c      |   4 +-
 drivers/staging/gpib/gpio/gpib_bitbang.c      |  41 +-
 drivers/staging/gpib/include/gpibP.h          |   8 +-
 drivers/staging/gpib/ines/ines_gpib.c         |   2 +-
 .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  69 ++--
 drivers/staging/gpib/nec7210/nec7210.c        |  34 +-
 drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 378 ++++++++++--------
 drivers/staging/gpib/tms9914/tms9914.c        |   8 +-
 drivers/staging/gpib/tnt4882/tnt4882_gpib.c   |   7 +-
 18 files changed, 551 insertions(+), 521 deletions(-)
Signature · 1 line
2.46.2