Skip to content

KVM: nVMX: Fix an SVI update bug with passthrough APIC

Sean Christopherson kvm lkml 2 versions – Applied

Status from this message: Applied to kvm-x86 vmx, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesApplied
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- WARN only if the vCPU is running to avoid false positives due to userspace stuffing APIC state while L2 is active. [Chao]
- Grab Chao's Tested-by.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2KVM: x86: Plumb in the vCPU to kvm_x86_ops.hwapic_isr_update()arch/x86/include/asm/kvm_host.h arch/x86/kvm/lapic.c arch/x86/kvm/vmx/vmx.c +1 more+8 -90 replies
2/2KVM: nVMX: Defer SVI update to vmcs01 on EOI when L2 is active w/o VIDarch/x86/kvm/lapic.c arch/x86/kvm/lapic.h arch/x86/kvm/vmx/nested.c +2 more+39 -01 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchChao Gao
1/2R-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] KVM: nVMX: Fix an SVI update bug with passthrough APIC

Defer updating SVI (i.e. the VMCS's highest ISR cache) when L2 is active, but L1 has not enabled virtual interrupt delivery for L2, as an EOI that is emulated _by KVM_ in such a case acts on L1's ISR, i.e. vmcs01 needs to reflect the updated ISR when L1 is next run.

Note, L1's ISR is also effectively L2's ISR in such a setup, but because virtual interrupt deliver is disable for L2, there's no need to update SVI in vmcs02, because it will never be used.

v2:
- WARN only if the vCPU is running to avoid false positives due to userspace stuffing APIC state while L2 is active. [Chao]
- Grab Chao's Tested-by.

v1: https://lore.kernel.org/all/[email protected]
Chao Gao (1):
KVM: nVMX: Defer SVI update to vmcs01 on EOI when L2 is active w/o VID

Sean Christopherson (1):
KVM: x86: Plumb in the vCPU to kvm_x86_ops.hwapic_isr_update()

 arch/x86/include/asm/kvm_host.h |  2 +-
 arch/x86/kvm/lapic.c            | 22 ++++++++++++++++------
 arch/x86/kvm/lapic.h            |  1 +
 arch/x86/kvm/vmx/nested.c       |  5 +++++
 arch/x86/kvm/vmx/vmx.c          | 23 ++++++++++++++++++++++-
 arch/x86/kvm/vmx/vmx.h          |  1 +
 arch/x86/kvm/vmx/x86_ops.h      |  2 +-
 7 files changed, 47 insertions(+), 9 deletions(-)

base-commit: 4d911c7abee56771b0219a9fbf0120d06bdc9c14

Signature · 1 line
2.47.0.338.g60cca15819-goog