Skip to content

'perf test' fixes/improvements

Arnaldo Carvalho de Melo linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Don't suppress the python binding test, instead skip it and tell the
reason: the binding isn't available.

- Treat NO_LIBTRACEVENT=1 like NO_LIBPYTHON=1, not suppressing tests, just skipping them, warn the user on explicit suppression of the library.

- Also reduce a patch description verbosity, as noted by Ian.

- Arnaldo

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf test python: Robustify the 'perf test python' test casetools/perf/tests/python-use.c+2 -20 replies
2/4perf test: Skip the python binding builtin test case with NO_LIBPYTHON=1tools/perf/tests/python-use.c+19 -10 replies
3/4perf test: Don't suppress the libtraceevent tests, skip themtools/perf/tests/Build tools/perf/tests/builtin-test.c tools/perf/tests/evsel-tp-sched.c +5 more+96 -203 replies
4/4perf build: Emit a warning when libtraceevent is explicitely disabledtools/perf/Makefile.config+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 perf-tools-next 0/4] 'perf test' fixes/improvements

Hi,

While evaluating what is needed for having shell tests that test
python functionality conditionally, i.e. so that we don't try to test the python binding if NO_LIBPYTHON=1 is used, I stumbled into these problems.

The first patch its more for documenting that strange system()
behaviour and to check if this was something that would have implications in other 'perf test' cases besides this python one, maybe somebody will spot the problem, but at least it seems more compact now using 'python -c inline-python-source'.

v2:

- Don't suppress the python binding test, instead skip it and tell the
reason: the binding isn't available.

- Treat NO_LIBTRACEVENT=1 like NO_LIBPYTHON=1, not suppressing tests, just skipping them, warn the user on explicit suppression of the library.

- Also reduce a patch description verbosity, as noted by Ian.

- Arnaldo

Arnaldo Carvalho de Melo (4):
perf test python: Robustify the 'perf test python' test case perf test: Skip the python binding builtin test case with NO_LIBPYTHON=1 perf test: Don't suppress the libtraceevent tests, skip them perf build: Emit a warning when libtraceevent is explicitely disabled

 tools/perf/Makefile.config                  |  4 +++-
 tools/perf/tests/Build                      | 12 +++++-----
 tools/perf/tests/builtin-test.c             |  6 -----
 tools/perf/tests/evsel-tp-sched.c           | 16 +++++++++++--
 tools/perf/tests/mmap-basic.c               | 26 +++++++++++++++++++--
 tools/perf/tests/openat-syscall-all-cpus.c  | 11 ++++++++-
 tools/perf/tests/openat-syscall-tp-fields.c | 11 ++++++++-
 tools/perf/tests/openat-syscall.c           | 11 ++++++++-
 tools/perf/tests/python-use.c               | 24 ++++++++++++++++---
 tools/perf/tests/switch-tracking.c          | 23 +++++++++++++++++-
 10 files changed, 120 insertions(+), 24 deletions(-)
Signature · 1 line
2.47.0