Skip to content

selftests: tmpfs: Add kselftest support

Shivam Chaudhary linux-kselftest lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest2 patches 1 replyIn review
  2. v72 patches 4 repliesSuperseded
  3. v62 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v52 patches3 repliesSuperseded
v42 patches2 repliesSuperseded

Changes in v8 from the cover letter

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2selftests: tmpfs: Add Test-skip if not run as roottools/testing/selftests/tmpfs/bug-link-o-tmpfile.c+12 -00 replies
2/2selftests: tmpfs: Add kselftest support to tmpfstools/testing/selftests/tmpfs/bug-link-o-tmpfile.c+14 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/2] selftests: tmpfs: Add kselftest support

This version 8 patch series replace direct error handling methods with ksft macros, which provide better reporting.Currently, when the tmpfs test runs, it does not display any output if it passes,and if it fails (particularly when not run as root),it simply exits without any warning or message.

This series of patch adds:

1. Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test outputs more effectively.

2. skip if not run as root.

3. Replace direct error handling with 'ksft_test_result_*', macros for better reporting.

v7->v8:
- Remove extra Prints
v7 v1: https://lore.kernel.org/all/[email protected]/
v7 v2: https://lore.kernel.org/all/[email protected]/

v6->v7:
- Improve the handling of failure macros.
v6 v1: https://lore.kernel.org/all/[email protected]/
v6 v2: https://lore.kernel.org/all/[email protected]/

v5->v6:
- Skip if not run as root.
v5 v1: https://lore.kernel.org/all/[email protected]/
v5 v2: https://lore.kernel.org/all/[email protected]/

v4->v5:
- Remove unnecessary pass messages.
- Remove unnecessary use of KSFT_SKIP.
- Add appropriate use of ksft_exit_fail_msg.
v4 v1: https://lore.kernel.org/all/[email protected]/
v4 v2: https://lore.kernel.org/all/[email protected]/

v3->v4:
- Start a patchset
- Split patch into smaller patches to make it easy to review.
Patch1 Replace 'ksft_test_result_skip' with 'KSFT_SKIP' during root run check. Patch2 Replace 'ksft_test_result_fail' with 'KSFT_SKIP' where fail does not make sense,
or failure could be due to not unsupported APIs with appropriate warnings.

v3: https://lore.kernel.org/all/[email protected]/

v2->v3:
- Remove extra ksft_set_plan()
- Remove function for unshare()
- Fix the comment style
v2: https://lore.kernel.org/all/[email protected]/

v1->v2:
- Make the commit message more clear.
v1: https://lore.kernel.org/all/[email protected]/T/#u

thanks
Shivam

Shivam Chaudhary (2):
selftests: tmpfs: Add Test-skip if not run as root
selftests: tmpfs: Add kselftest support to tmpfs

 .../selftests/tmpfs/bug-link-o-tmpfile.c      | 41 ++++++++++++-------
 1 file changed, 26 insertions(+), 15 deletions(-)
Signature · 1 line
2.34.1