Skip to content

nfs/nfsd: improvements for LOCALIO

Mike Snitzer linux-nfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 9 repliesIn review
  2. v215 patches 6 repliesApplied
  3. v119 patches 25 repliesSuperseded

Changes in v3 from the cover letter

- switched from rcu_assign_pointer to RCU_INIT_POINTER when setting to NULL.
- removed some unnecessary #if IS_ENABLED(CONFIG_NFS_LOCALIO)
- revised the NFS v3 probe patch to use a new nfsv3.ko modparam 'nfs3_localio_probe_throttle' to control if NFSv3 will probe for LOCALIO. Avoids use of NFS_CS_LOCAL_IO and will probe every 'nfs3_localio_probe_throttle' IO requests (defaults to 0, disabled).
- added "Module Parameters" section to localio.rst

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14nfs/localio: add direct IO enablement with sync and async IO supportDocumentation/filesystems/nfs/localio.rst fs/nfs/direct.c fs/nfs/localio.c +1 more+96 -100 replies
2/14nfsd: add nfsd_file_{get,put} to 'nfs_to' nfsd_localio_operationsfs/nfsd/localio.c include/linux/nfslocalio.h+4 -00 replies
3/14nfs_common: rename functions that invalidate LOCALIO nfs_clientsfs/nfs/localio.c fs/nfs_common/nfslocalio.c fs/nfsd/nfsctl.c +1 more+10 -90 replies
4/14nfs_common: move localio_lock to new lock member of nfs_uuid_tfs/nfs/client.c fs/nfs/localio.c fs/nfs_common/nfslocalio.c +2 more+51 -300 replies
5/14nfs: cache all open LOCALIO nfsd_file(s) in clientfs/nfs/flexfilelayout/flexfilelayout.c fs/nfs/flexfilelayout/flexfilelayout.h fs/nfs/inode.c +7 more+177 -450 replies
6/14nfsd: update percpu_ref to manage references on nfsd_netfs/nfsd/nfssvc.c+7 -50 replies
7/14nfsd: rename nfsd_serv_ prefixed methods and variables with nfsd_net_Documentation/filesystems/nfs/localio.rst fs/nfs_common/nfslocalio.c fs/nfsd/filecache.c +4 more+64 -900 replies
8/14nfsd: nfsd_file_acquire_local no longer returns GC'd nfsd_filefs/nfsd/filecache.c+4 -50 replies
9/14nfs_common: rename nfslocalio nfs_uuid_lock to nfs_uuids_lockfs/nfs_common/nfslocalio.c fs/nfsd/localio.c+18 -180 replies
10/14nfs_common: track all open nfsd_files per LOCALIO nfs_clientfs/nfs_common/nfslocalio.c fs/nfsd/filecache.c fs/nfsd/localio.c +3 more+144 -470 replies
11/14nfs_common: add nfs_localio trace eventsfs/nfs_common/Makefile fs/nfs_common/localio_trace.c fs/nfs_common/localio_trace.h +1 more+72 -10 replies
12/14nfs/localio: remove redundant code and simplify LOCALIO enablementfs/nfs/client.c fs/nfs/internal.h fs/nfs/localio.c +4 more+22 -830 replies
13/14nfs: probe for LOCALIO when v4 client reconnects to serverfs/nfs/client.c fs/nfs/internal.h fs/nfs/localio.c +2 more+20 -00 replies
14/14nfs: probe for LOCALIO when v3 client reconnects to serverDocumentation/filesystems/nfs/localio.rst fs/nfs/nfs3proc.c fs/nfs_common/nfslocalio.c +1 more+65 -50 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNeilBrownJeff LaytonChuck Lever
SeriesR-b A-b
1/14
2/14
3/14R-b
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [for-6.13 PATCH v3 00/14] nfs/nfsd: improvements for LOCALIO

Hi,

All available here:
https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=nfs-localio-for-next

Changes since v2:
- switched from rcu_assign_pointer to RCU_INIT_POINTER when setting to NULL.
- removed some unnecessary #if IS_ENABLED(CONFIG_NFS_LOCALIO)
- revised the NFS v3 probe patch to use a new nfsv3.ko modparam 'nfs3_localio_probe_throttle' to control if NFSv3 will probe for LOCALIO. Avoids use of NFS_CS_LOCAL_IO and will probe every 'nfs3_localio_probe_throttle' IO requests (defaults to 0, disabled).
- added "Module Parameters" section to localio.rst

All review appreciated, thanks.
Mike

Mike Snitzer (14):
nfs/localio: add direct IO enablement with sync and async IO support
nfsd: add nfsd_file_{get,put} to 'nfs_to' nfsd_localio_operations
nfs_common: rename functions that invalidate LOCALIO nfs_clients
nfs_common: move localio_lock to new lock member of nfs_uuid_t
nfs: cache all open LOCALIO nfsd_file(s) in client
nfsd: update percpu_ref to manage references on nfsd_net
nfsd: rename nfsd_serv_ prefixed methods and variables with nfsd_net_
nfsd: nfsd_file_acquire_local no longer returns GC'd nfsd_file
nfs_common: rename nfslocalio nfs_uuid_lock to nfs_uuids_lock
nfs_common: track all open nfsd_files per LOCALIO nfs_client
nfs_common: add nfs_localio trace events
nfs/localio: remove redundant code and simplify LOCALIO enablement
nfs: probe for LOCALIO when v4 client reconnects to server
nfs: probe for LOCALIO when v3 client reconnects to server

 Documentation/filesystems/nfs/localio.rst |  98 +++++----
 fs/nfs/client.c                           |   6 +-
 fs/nfs/direct.c                           |   1 +
 fs/nfs/flexfilelayout/flexfilelayout.c    |  25 +--
 fs/nfs/flexfilelayout/flexfilelayout.h    |   1 +
 fs/nfs/inode.c                            |   3 +
 fs/nfs/internal.h                         |   9 +-
 fs/nfs/localio.c                          | 232 +++++++++++++++-----
 fs/nfs/nfs3proc.c                         |  46 +++-
 fs/nfs/nfs4state.c                        |   1 +
 fs/nfs/nfstrace.h                         |  32 ---
 fs/nfs/pagelist.c                         |   5 +-
 fs/nfs/write.c                            |   3 +-
 fs/nfs_common/Makefile                    |   3 +-
 fs/nfs_common/localio_trace.c             |  10 +
 fs/nfs_common/localio_trace.h             |  56 +++++
 fs/nfs_common/nfslocalio.c                | 250 +++++++++++++++++-----
 fs/nfsd/filecache.c                       |  20 +-
 fs/nfsd/localio.c                         |   9 +-
 fs/nfsd/netns.h                           |  12 +-
 fs/nfsd/nfsctl.c                          |   6 +-
 fs/nfsd/nfssvc.c                          |  40 ++--
 include/linux/nfs_fs.h                    |  22 +-
 include/linux/nfs_fs_sb.h                 |   3 +-
 include/linux/nfs_xdr.h                   |   1 +
 include/linux/nfslocalio.h                |  48 +++--
 26 files changed, 674 insertions(+), 268 deletions(-)
 create mode 100644 fs/nfs_common/localio_trace.c
 create mode 100644 fs/nfs_common/localio_trace.h
Signature · 1 line
2.44.0