Skip to content

RFC Address rename/readdir bugs in fs/libfs.c

[email protected] amd-gfx dri-devel linux-fsdevel linux-mm lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libfs: Define a minimum directory offsetfs/libfs.c+8 -50 replies
2/6libfs: Add simple_offset_empty()fs/libfs.c include/linux/fs.h mm/shmem.c+35 -20 replies
3/6libfs: Fix simple_offset_rename_exchange()fs/libfs.c+19 -60 replies
4/6libfs: Add simple_offset_rename() APIfs/libfs.c include/linux/fs.h mm/shmem.c+24 -20 replies
5/6shmem: Fix shmem_rename2()fs/libfs.c+9 -00 replies
6/6libfs: fix infinite directory reads for offset dirfs/libfs.c+25 -128 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchJan KaraChuck Lever
1/6R-b
2/6R-b
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/6 6.6] Address rename/readdir bugs in fs/libfs.c

From: Chuck Lever <[email protected]>

Address several bugs in v6.6's libfs/shmemfs, including CVE-2024-46701.

I'm still running the usual set of regression tests, but so far this set looks stable. I'm interested in hearing review comments and test results.

Branch for testing: https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-6.6.y

Chuck Lever (5):
libfs: Define a minimum directory offset
libfs: Add simple_offset_empty()
libfs: Fix simple_offset_rename_exchange()
libfs: Add simple_offset_rename() API
shmem: Fix shmem_rename2()

yangerkun (1):
libfs: fix infinite directory reads for offset dir

 fs/libfs.c         | 135 +++++++++++++++++++++++++++++++++++++--------
 include/linux/fs.h |   3 +
 mm/shmem.c         |   7 +--
 3 files changed, 119 insertions(+), 26 deletions(-)
Signature · 1 line
2.47.0