Skip to content

pinctrl: sunxi: Add Allwinner A523 support

Andre Przywara linux-arm-kernel linux-devicetree linux-gpio linux-sunxi lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 2/220 patches 13 repliesIn review
  2. v4 Latest8 patches 2 repliesIn review
  3. v38 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/28 patches9 repliesSuperseded
v17 patches7 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8pinctrl: sunxi: refactor pinctrl variants into flagsdrivers/pinctrl/sunxi/pinctrl-sun20i-d1.c drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c drivers/pinctrl/sunxi/pinctrl-sun5i.c +4 more+36 -340 replies
2/8pinctrl: sunxi: increase number of GPIO bank regulatorsdrivers/pinctrl/sunxi/pinctrl-sunxi.h+1 -10 replies
3/8pinctrl: sunxi: move bank K register offsetdrivers/pinctrl/sunxi/pinctrl-sunxi.c drivers/pinctrl/sunxi/pinctrl-sunxi.h+25 -80 replies
4/8pinctrl: sunxi: support moved power configuration registersdrivers/pinctrl/sunxi/pinctrl-sunxi.c drivers/pinctrl/sunxi/pinctrl-sunxi.h+16 -61 reply
5/8pinctrl: sunxi: allow reading mux values from DTdrivers/pinctrl/sunxi/Makefile drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c drivers/pinctrl/sunxi/pinctrl-sunxi.h+384 -00 replies
6/8dt-bindings: pinctrl: add compatible for Allwinner A523/T527Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml+175 -00 replies
7/8pinctrl: sunxi: Add support for the Allwinner A523drivers/pinctrl/sunxi/Kconfig drivers/pinctrl/sunxi/Makefile drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c+60 -00 replies
8/8pinctrl: sunxi: Add support for the secondary A523 GPIO portsdrivers/pinctrl/sunxi/Kconfig drivers/pinctrl/sunxi/Makefile drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c+60 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJernej SkrabecChen-Yu TsaiRob Herring (Arm)
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/8] pinctrl: sunxi: Add Allwinner A523 support

Hi,

this is the fourth drop of the series introducing pinctrl support for the Allwinner A523 family of SoCs (comprising A523, A527, T527, H728). [1] This time only a small fix, spotted by Jernej, thanks for that. Also adding the new tags. Changelog below.

==============
The first four patches extend the sunxi pinctrl core code to deal with some specialities of the new SoC: it uses every of the 11 possible banks except the first one, which required some register remapping. The first patch here is some cleanup, which we should take regardless, I think, since it fixes some hack we introduced with the D1 support.

The main feature is actually patch 5, which introduces a new way to express the required pinmux values for each function/pin pair. Traditionally, we dumped a rather large table of data into the (single image!) kernel for that, but this approach now puts that value into the DT, and builds the table at runtime. This patch was posted twice before [2][3], the last time LinusW seemed to be fine with the idea, just complained about the abuse of the generic pinmux property. I changed that to allwinner,pinmux now.

The rest of the patches are the usual suspects: the two files for the two pinctrl instances of the new SoC (now very small), and the DT binding.

Based on v6.14-rc1. Please have a look, review and test!

Cheers,
Andre

[1] https://linux-sunxi.org/A523#Family_of_sun55iw3
[2] https://patchwork.ozlabs.org/project/linux-gpio/cover/[email protected]/
[3] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Changelog v3 .. v4:
- fix mixed up POW_MOD_SEL registers
- add review tags (with thanks!)

Changelog v2 .. v3:
- rename POW_MOD_SEL symbol
- drop CCU binding header inclusion in DT binding example
- add review tags (with thanks!)

Changelog v1 .. v2:
- rebased on v6.14-rc1
- extend regulator array to cover PortK as well
- increase number of pins in A523 PortJ from 18 to 28
- extend comment for new pinctrl DT code
- move DT binding into separate yaml file
- Add Jernej's Reviewed-by (with thanks!)

Andre Przywara (8):
pinctrl: sunxi: refactor pinctrl variants into flags
pinctrl: sunxi: increase number of GPIO bank regulators
pinctrl: sunxi: move bank K register offset
pinctrl: sunxi: support moved power configuration registers
pinctrl: sunxi: allow reading mux values from DT
dt-bindings: pinctrl: add compatible for Allwinner A523/T527
pinctrl: sunxi: Add support for the Allwinner A523
pinctrl: sunxi: Add support for the secondary A523 GPIO ports

 .../allwinner,sun55i-a523-pinctrl.yaml        | 175 ++++++++
 drivers/pinctrl/sunxi/Kconfig                 |  10 +
 drivers/pinctrl/sunxi/Makefile                |   3 +
 drivers/pinctrl/sunxi/pinctrl-sun20i-d1.c     |   6 +-
 drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c     |   8 +-
 drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c |  54 +++
 drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c   |  54 +++
 drivers/pinctrl/sunxi/pinctrl-sun5i.c         |   8 +-
 drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c     |   8 +-
 drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c     |   7 +-
 drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c      | 374 ++++++++++++++++++
 drivers/pinctrl/sunxi/pinctrl-sunxi.c         |  54 ++-
 drivers/pinctrl/sunxi/pinctrl-sunxi.h         |  47 ++-
 13 files changed, 758 insertions(+), 50 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
 create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c
 create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c
 create mode 100644 drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c
Signature · 1 line
2.46.3