Skip to content

RFC Remove automake patch that changes path to test-driver

[email protected] openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5attr: Fix the ptest path to test-drivermeta/recipes-support/attr/attr.inc+7 -42 replies
2/5sed: Fix the ptest path to test-drivermeta/recipes-extended/sed/sed_4.9.bb+1 -00 replies
3/5parted: Fix the ptest path to test-drivermeta/recipes-extended/parted/parted_3.6.bb+9 -70 replies
4/5strace: Fix the ptest path to test-drivermeta/recipes-devtools/strace/strace_6.11.bb+3 -10 replies
5/5automake: Remove patch that changes path to test-drivermeta/recipes-devtools/automake/automake/0005-Set-relative-to-top_builddir-path-in-Makefile-to-acc.patch meta/recipes-devtools/automake/automake_1.17.bb+0 -510 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] Remove automake patch that changes path to test-driver

From: Ola x Nilsson <[email protected]>

Fixes [YOCTO #15635]

The automake patch
"Set relative to top_builddir path in Makefile to access" sets the default path of test-driver to $(top_builddir)/$(config_aux_dir) instead of the normal $(top_srcdir)/$(config_aux_dir).

This breaks check test for Automake projects in generated images.

To reproduce, use core-image-kernel-dev with git added.

git clone https://git.kernel.org/pub/scm/linux/kernel/git/kay/libabc.git
(cd libabc && ./autogen.sh)
mkdir build
cd build
../libabc/configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib make check

/bin/sh: ./build-aux/test-driver: No such file or directory

Removing the patch makes the checks complete successfully.

Some ptests depend on this patch to find test-driver. They need to be addressed individually. In all cases I've found so far this is just another sed substitution and should work even before removing the patch.

I have not verified the ptests in meta-openembedded yet, but I'm working on it.

Ola x Nilsson (5):
attr: Fix the ptest path to test-driver
sed: Fix the ptest path to test-driver
parted: Fix the ptest path to test-driver
strace: Fix the ptest path to test-driver
automake: Remove patch that changes path to test-driver

 ...top_builddir-path-in-Makefile-to-acc.patch | 50 -------------------
 .../automake/automake_1.17.bb                 |  1 -
 meta/recipes-devtools/strace/strace_6.11.bb   |  4 +-
 meta/recipes-extended/parted/parted_3.6.bb    | 16 +++---
 meta/recipes-extended/sed/sed_4.9.bb          |  1 +
 meta/recipes-support/attr/attr.inc            | 11 ++--
 6 files changed, 20 insertions(+), 63 deletions(-)
 delete mode 100644 meta/recipes-devtools/automake/automake/0005-Set-relative-to-top_builddir-path-in-Makefile-to-acc.patch
Signature · 1 line
2.39.5