Skip to content

drm/dumb-buffers: Fix and improve buffer-size calculation

Thomas Zimmermann dri-devel imx intel-xe linux-arm-msm linux-mediatek linux-renesas-soc linux-rockchip linux-samsung-soc linux-tegra nouveau virtualization xen-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest25 patches 11 repliesIn review
  2. v525 patches 12 repliesSuperseded
  3. v425 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v325 patches17 repliesSuperseded
v225 patches46 repliesSuperseded
v15 patches0 repliesSuperseded

Changes in v6 from the cover letter

- extend TODO item (Tomi)
- fix typos in documentation (Tomi)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25drm/dumb-buffers: Sanitize output on errorsdrivers/gpu/drm/drm_dumb_buffers.c+29 -110 replies
2/25drm/dumb-buffers: Provide helper to set pitch and sizeDocumentation/gpu/todo.rst drivers/gpu/drm/drm_dumb_buffers.c include/drm/drm_dumb_buffers.h +1 more+230 -10 replies
3/25drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/drm_gem_dma_helper.c drivers/gpu/drm/imx/ipuv3/imx-drm-core.c+8 -35 replies
4/25drm/gem-shmem: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/drm_gem_shmem_helper.c+5 -110 replies
5/25drm/gem-vram: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/drm_gem_vram_helper.c+23 -10 replies
6/25drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/armada/armada_gem.c+7 -90 replies
7/25drm/exynos: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/exynos/exynos_drm_gem.c+5 -30 replies
8/25drm/gma500: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/gma500/gem.c+6 -150 replies
9/25drm/hibmc: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c include/drm/drm_gem_vram_helper.h+24 -720 replies
10/25drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/imx/ipuv3/imx-drm-core.c+23 -80 replies
11/25drm/loongson: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/loongson/lsdc_gem.c+8 -210 replies
12/25drm/mediatek: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/mediatek/mtk_gem.c+4 -90 replies
13/25drm/msm: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/msm/msm_gem.c+25 -21 reply
14/25drm/nouveau: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/nouveau/nouveau_display.c+4 -30 replies
15/25drm/omapdrm: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/omapdrm/omap_gem.c+7 -80 replies
16/25drm/qxl: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/qxl/qxl_dumb.c+8 -90 replies
17/25drm/renesas/rcar-du: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c+5 -20 replies
18/25drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c+5 -33 replies
19/25drm/rockchip: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/rockchip/rockchip_drm_gem.c+6 -60 replies
20/25drm/tegra: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/tegra/gem.c+5 -30 replies
21/25drm/virtio: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/virtio/virtgpu_gem.c+5 -60 replies
22/25drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/vmwgfx/vmwgfx_surface.c+4 -170 replies
23/25drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/xe/xe_bo.c+4 -41 reply
24/25drm/xen: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/xen/xen_drm_front.c+5 -20 replies
25/25drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()drivers/gpu/drm/xlnx/zynqmp_kms.c+5 -20 replies

Reviews trailers per patch

16 of 25 patches have a Reviewed-by or Acked-by.

PatchTomi ValkeinenInki DaePhilipp ZabelSui JingfengDmitry BaryshkovLyude PaulThierry RedingZack RusinLaurent PinchartHeiko StuebnerMatthew AuldBiju DasLucas De Marchi
1/25R-b
2/25R-b R-b
3/25R-b
4/25R-b
5/25
6/25
7/25A-b
8/25
9/25
10/25R-b
11/25R-b
12/25
13/25R-b
14/25R-b
15/25R-b
16/25
17/25R-b R-b
18/25T-b
19/25A-b
20/25A-b
21/25
22/25R-b
23/25R-b A-b
24/25
25/25R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 13 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation

Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-specific alignments. The calculation of these values is inconsistent and duplicated among drivers. The results for formats with bpp < 8 are sometimes incorrect.

This series fixes this for most drivers. Default scanline pitch and buffer size are now calculated with the existing 4CC helpers. There is a new helper drm_mode_size_dumb() that calculates scanline pitch and buffer size according to driver requirements.

The series fixes the common GEM implementations for DMA, SHMEM and VRAM. It further changes most implementations of dumb_create to use the new helper. A small number of drivers has more complicated calculations and will be updated by a later patches.

v6:
- extend TODO item (Tomi)
- fix typos in documentation (Tomi)
v5:
- use check_mul_overflow() for overflow test (Tomi)
- imx: fix intermediate code (Tomi)
- rz-du: include dumb-buffers header
v4:
- improve UAPI documentation
- document bpp special cases
- use drm_warn_once()
- add TODO lists
- armada: fix pitch alignment
v3:
- document UAPI semantics
- fall back to bpp-based allocation for unknown color modes
- cleanups
v2:
- rewrite series
- convert many individual drivers besides the shared GEM helpers

Thomas Zimmermann (25):
drm/dumb-buffers: Sanitize output on errors drm/dumb-buffers: Provide helper to set pitch and size drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/gem-shmem: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/gem-vram: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/exynos: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/gma500: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/hibmc: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/loongson: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/mediatek: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/msm: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/nouveau: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/omapdrm: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/qxl: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/renesas/rcar-du: Compute dumb-buffer sizes with
drm_mode_size_dumb()
drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/rockchip: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/tegra: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/virtio: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/xen: Compute dumb-buffer sizes with drm_mode_size_dumb() drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

 Documentation/gpu/todo.rst                    |  37 ++++
 drivers/gpu/drm/armada/armada_gem.c           |  16 +-
 drivers/gpu/drm/drm_dumb_buffers.c            | 170 ++++++++++++++++--
 drivers/gpu/drm/drm_gem_dma_helper.c          |   7 +-
 drivers/gpu/drm/drm_gem_shmem_helper.c        |  16 +-
 drivers/gpu/drm/drm_gem_vram_helper.c         |  89 +++------
 drivers/gpu/drm/exynos/exynos_drm_gem.c       |   8 +-
 drivers/gpu/drm/gma500/gem.c                  |  21 +--
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |  25 ++-
 drivers/gpu/drm/imx/ipuv3/imx-drm-core.c      |  29 ++-
 drivers/gpu/drm/loongson/lsdc_gem.c           |  29 +--
 drivers/gpu/drm/mediatek/mtk_gem.c            |  13 +-
 drivers/gpu/drm/msm/msm_gem.c                 |  27 ++-
 drivers/gpu/drm/nouveau/nouveau_display.c     |   7 +-
 drivers/gpu/drm/omapdrm/omap_gem.c            |  15 +-
 drivers/gpu/drm/qxl/qxl_dumb.c                |  17 +-
 drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c |   7 +-
 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c  |   8 +-
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c   |  12 +-
 drivers/gpu/drm/tegra/gem.c                   |   8 +-
 drivers/gpu/drm/virtio/virtgpu_gem.c          |  11 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_surface.c       |  21 +--
 drivers/gpu/drm/xe/xe_bo.c                    |   8 +-
 drivers/gpu/drm/xen/xen_drm_front.c           |   7 +-
 drivers/gpu/drm/xlnx/zynqmp_kms.c             |   7 +-
 include/drm/drm_dumb_buffers.h                |  14 ++
 include/drm/drm_gem_vram_helper.h             |   6 -
 include/uapi/drm/drm_mode.h                   |  50 +++++-
 28 files changed, 457 insertions(+), 228 deletions(-)
 create mode 100644 include/drm/drm_dumb_buffers.h
Signature · 1 line
2.50.1