xfs: miscellaneous bug fixes
Status from this message: Applied to for-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | xfs: fix sparse inode limits on runt AGfs/ | +9 | 3 replies | |
| 2/3 | xfs: delalloc and quota softlimit timers are incoherentfs/ | +0 | 3 replies | |
| 3/3 | xfs: prevent mount and log shutdown racefs/ fs/ | +12 | 3 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong | Christoph Hellwig |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | R-b | R-b |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] xfs: miscellaneous bug fixes
These are three bug fixes for recent issues.
The first is a repost of the original patch to prevent allocation of sparse inode clusters at the end of an unaligned runt AG. There was plenty of discussion over that fix here:
https://lore.kernel.org/linux-xfs/[email protected]/
And the outcome of that discussion is that we can't allow sparse inode clusters overlapping the end of the runt AG without an on disk format definition change. Hence this patch to ensure the check is done correctly is the only change we need to make to the kernel to avoid this problem in the future.
Filesystems that have this problem on disk will need to run xfs_repair to remove the bad cluster, but no data loss is possible from this because the kernel currently disallows inode allocation from the bad cluster and so none of the inodes in the sparse cluster can actually be used. Hence there is no possible data loss or other metadata corruption possible from this situation, all we need to do is ensure that it doesn't happen again once repair has done it's work.
The other two patches are for issues I've recently hit when running lots of fstests in parallel. That changes loading and hence timing of events during tests, exposing latent race conditions in the code. The quota fix removes racy debug code that has been there since the quota code was first committed in 1996.
The log shutdown race fix is a much more recent issue created by trying to ensure shutdowns operate in a sane and predictable manner. The logic flaw is that we allow multiple log shutdowns to start and force the log before selecting on a single log shutdown task. This leads to a situation where shutdown log item callback processing gets stuck waiting on a task holding a buffer lock that is waiting on a log force that is waiting on shutdown log item callback processing to complete...
Thoughts?