PCI endpoint additional pci_epc_set_bar() checks
Status from this message: Applied to endpoint, thank you!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest6 patches 1 replyApplied
- v56 patches 7 repliesSuperseded
- v45 patches 5 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 4 patches | 0 replies | Superseded | |
| v2 | 3 patches | 2 replies | Superseded | |
| v1 | 3 patches | 4 replies | Superseded |
Changes in v6 from the cover letter
-Picked up tags.
-Add Cc: stable for patch 2/6.
-Improved commit messages in patch 1/6 and patch 2/6. -Improved code comment in patch 2/6 to be more specific.
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | PCI: dwc: ep: Write BAR_MASK before iATU registers in pci_epc_set_bar()drivers/ | +15 | 0 replies | |
| 2/6 | PCI: dwc: ep: Prevent changing BAR size/flags in pci_epc_set_bar()drivers/ | +21 | 0 replies | |
| 3/6 | PCI: dwc: ep: Add 'address' alignment to 'size' check in dw_pcie_prog_ep_inbound_atu()drivers/ drivers/ drivers/ | +9 | 0 replies | |
| 4/6 | PCI: artpec6: Implement dw_pcie_ep operation get_featuresdrivers/ | +13 | 0 replies | |
| 5/6 | PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar()drivers/ | +9 | 0 replies | |
| 6/6 | PCI: endpoint: Verify that requested BAR size is a power of twodrivers/ | +3 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Manivannan Sadhasivam | Frank Li | Jesper Nilsson |
|---|---|---|---|
| 1/6 | R-b | ||
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | R-b | A-b |
| 5/6 | R-b | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/6] PCI endpoint additional pci_epc_set_bar() checks
Hello all,
This series adds some extra checks to ensure that it is not possible to program the iATU with an address which we did not intend to use.
If these checks were in place when testing some of the earlier revisions of Frank's doorbell patches (which did not handle fixed BARs properly), we would gotten an error, rather than silently using an address which we did not intend to use.
Having these checks in place will hopefully avoid similar debugging in the future.
Kind regards,
Niklas
Changes since v5:
-Picked up tags.
-Add Cc: stable for patch 2/6.
-Improved commit messages in patch 1/6 and patch 2/6. -Improved code comment in patch 2/6 to be more specific.
Niklas Cassel (6):
PCI: dwc: ep: Write BAR_MASK before iATU registers in
pci_epc_set_bar()
PCI: dwc: ep: Prevent changing BAR size/flags in pci_epc_set_bar()
PCI: dwc: ep: Add 'address' alignment to 'size' check in
dw_pcie_prog_ep_inbound_atu()
PCI: artpec6: Implement dw_pcie_ep operation get_features
PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar()
PCI: endpoint: Verify that requested BAR size is a power of two
drivers/pci/controller/dwc/pcie-artpec6.c | 13 +++++ .../pci/controller/dwc/pcie-designware-ep.c | 52 ++++++++++++++----- drivers/pci/controller/dwc/pcie-designware.c | 5 +- drivers/pci/controller/dwc/pcie-designware.h | 2 +- drivers/pci/endpoint/pci-epc-core.c | 14 ++++- 5 files changed, 67 insertions(+), 19 deletions(-)
Signature · 1 line
2.47.1