Prefer evsel over evsel->core.idx
Status from this message: Thanks, applied to perf-tools-next,
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf stream: Use evsel rather than evsel->idxtools/ tools/ tools/ | +10 | 0 replies | |
| 2/3 | perf values: Use evsel rather than evsel->idxtools/ tools/ tools/ | +51 | 0 replies | |
| 3/3 | perf annotate: Prefer passing evsel to evsel->core.idxtools/ tools/ tools/ +1 more | +29 | 1 reply |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | James Clark | Namhyung Kim |
|---|---|---|
| Series | R-b R-b | R-b R-b |
| 1/3 | ||
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/3] Prefer evsel over evsel->core.idx
James Clark's patches fixing evsel->core.idx [1] reminded me that we pass the int value around unnecessarily. Passing the evsel avoids issues if the evlist is reordered but paired with sanitizers we can also know when something is used when it shouldn't be. These patches do some initial work reducing the use of evsel->core.idx or reducing the API to pass evsels and not their interior index.
[1] https://lore.kernel.org/lkml/[email protected]/
Ian Rogers (3):
perf stream: Use evsel rather than evsel->idx perf values: Use evsel rather than evsel->idx perf annotate: Prefer passing evsel to evsel->core.idx
tools/perf/builtin-diff.c | 4 +- tools/perf/builtin-report.c | 4 +- tools/perf/builtin-top.c | 4 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/util/annotate.c | 32 +++++---- tools/perf/util/annotate.h | 20 +++--- tools/perf/util/stream.c | 7 +- tools/perf/util/stream.h | 10 +-- tools/perf/util/values.c | 106 +++++++++++++----------------- tools/perf/util/values.h | 9 +-- 10 files changed, 90 insertions(+), 108 deletions(-)
Signature · 1 line
2.47.0.338.g60cca15819-goog