Skip to content

Prefer evsel over evsel->core.idx

Ian Rogers linux-perf-users lkml 1 version Applied

Status from this message: Thanks, applied to perf-tools-next,

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3perf stream: Use evsel rather than evsel->idxtools/perf/builtin-diff.c tools/perf/util/stream.c tools/perf/util/stream.h+10 -110 replies
2/3perf values: Use evsel rather than evsel->idxtools/perf/builtin-report.c tools/perf/util/values.c tools/perf/util/values.h+51 -680 replies
3/3perf annotate: Prefer passing evsel to evsel->core.idxtools/perf/builtin-top.c tools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c +1 more+29 -291 reply

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJames ClarkNamhyung Kim
SeriesR-b R-b R-b R-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/3] Prefer evsel over evsel->core.idx

James Clark's patches fixing evsel->core.idx [1] reminded me that we pass the int value around unnecessarily. Passing the evsel avoids issues if the evlist is reordered but paired with sanitizers we can also know when something is used when it shouldn't be. These patches do some initial work reducing the use of evsel->core.idx or reducing the API to pass evsels and not their interior index.

[1] https://lore.kernel.org/lkml/[email protected]/

Ian Rogers (3):
perf stream: Use evsel rather than evsel->idx perf values: Use evsel rather than evsel->idx perf annotate: Prefer passing evsel to evsel->core.idx

 tools/perf/builtin-diff.c         |   4 +-
 tools/perf/builtin-report.c       |   4 +-
 tools/perf/builtin-top.c          |   4 +-
 tools/perf/ui/browsers/annotate.c |   2 +-
 tools/perf/util/annotate.c        |  32 +++++----
 tools/perf/util/annotate.h        |  20 +++---
 tools/perf/util/stream.c          |   7 +-
 tools/perf/util/stream.h          |  10 +--
 tools/perf/util/values.c          | 106 +++++++++++++-----------------
 tools/perf/util/values.h          |   9 +--
 10 files changed, 90 insertions(+), 108 deletions(-)
Signature · 1 line
2.47.0.338.g60cca15819-goog