Skip to content

UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

Kees Cook linux-hardening lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3Revert "net: ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings"drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +6 more+22 -260 repliesApplied
2/3Revert "UAPI: ethtool: Use __struct_group() in struct ethtool_link_settings"include/uapi/linux/ethtool.h+15 -180 repliesApplied
3/3UAPI: ethtool: Avoid flex-array in struct ethtool_link_settingsinclude/uapi/linux/ethtool.h+7 -01 replyApplied

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchJakub Kicinski
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

Hi,

This reverts the tagged struct group in struct ethtool_link_settings and instead just removes the flexible array member from Linux's view as it is entirely unused.

-Kees

Kees Cook (3):
Revert "net: ethtool: Avoid thousands of
-Wflex-array-member-not-at-end warnings"
Revert "UAPI: ethtool: Use __struct_group() in struct
ethtool_link_settings"
UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  6 +--
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  4 +-
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |  2 +-
 .../net/ethernet/cisco/enic/enic_ethtool.c    |  2 +-
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  4 +-
 include/linux/ethtool.h                       |  2 +-
 include/uapi/linux/ethtool.h                  | 40 ++++++++++---------
 net/ethtool/ioctl.c                           |  2 +-
 net/ethtool/linkinfo.c                        |  8 ++--
 net/ethtool/linkmodes.c                       | 18 ++++-----
 10 files changed, 44 insertions(+), 44 deletions(-)
Signature · 1 line
2.34.1