Skip to content

btrfs: fix reading from userspace in btrfs_uring_encoded_read()

Mark Harmstone io-uring linux-btrfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 7 repliesIn review
  2. v34 patches 0 repliesSuperseded
  3. v23 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches3 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4io_uring/cmd: rename struct uring_cache to io_uring_cmd_datainclude/linux/io_uring/cmd.h io_uring/io_uring.c io_uring/opdef.c +2 more+12 -110 replies
2/4io_uring/cmd: add per-op data to struct io_uring_cmd_datainclude/linux/io_uring/cmd.h io_uring/uring_cmd.c+12 -24 replies
3/4io_uring: add io_uring_cmd_get_async_data helperinclude/linux/io_uring/cmd.h+5 -00 replies
4/4btrfs: don't read from userspace twice in btrfs_uring_encoded_read()fs/btrfs/ioctl.c+68 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] btrfs: fix reading from userspace in btrfs_uring_encoded_read()

Version 4 of mine and Jens' patches, to make sure that when our io_uring function gets called a second time, it doesn't accidentally read something from userspace that's gone out of scope or otherwise gotten corrupted.

I sent a version 3 on December 17, but it looks like that got forgotten about over Christmas (unsurprisingly). Version 4 fixes a problem that I noticed, namely that we weren't taking a copy of the iovs, which also necessitated creating a struct to store these things in. This does simplify things by removing the need for the kmemdup, however.

I also have a patch for io_uring encoded writes ready to go, but it's waiting on some of the stuff introduced here.

Jens Axboe (2):
io_uring/cmd: rename struct uring_cache to io_uring_cmd_data io_uring/cmd: add per-op data to struct io_uring_cmd_data

Mark Harmstone (2):
io_uring: add io_uring_cmd_get_async_data helper
btrfs: don't read from userspace twice in btrfs_uring_encoded_read()

 fs/btrfs/ioctl.c             | 125 +++++++++++++++++++----------------
 include/linux/io_uring/cmd.h |  10 +++
 io_uring/io_uring.c          |   2 +-
 io_uring/opdef.c             |   3 +-
 io_uring/uring_cmd.c         |  23 +++++--
 io_uring/uring_cmd.h         |   4 --
 6 files changed, 97 insertions(+), 70 deletions(-)
Signature · 1 line
2.45.2