Skip to content

Support for the RK3576

Heiko Stuebner u-boot 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 15 repliesIn review
  2. v216 patches 13 repliesSuperseded
  3. v120 patches 23 repliesSuperseded

Changes in v3 from the cover letter

- drop unneeded syscon-ids
- drop !XPL_BULLD limit from rk3576_common.h
- drop nr_pins from pinctrl
- move SYS_CONFIG_NAME symbol in rk3576/Kconfig
- one more CFG_SYS_SDRAM_BASE nitpick :-)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15rockchip: sdram: honor CFG_SYS_SDRAM_BASE when defining ram regionsarch/arm/mach-rockchip/sdram.c+6 -61 reply
2/15rockchip: mkimage: Add rk3576 supporttools/rkcommon.c+1 -01 reply
3/15arm: rockchip: Add RK3576 arch core supportarch/arm/dts/rk3576-u-boot.dtsi arch/arm/include/asm/arch-rk3576/boot0.h arch/arm/include/asm/arch-rk3576/gpio.h +10 more+475 -01 reply
4/15pinctrl: rockchip: support rk3576 pinctrldrivers/pinctrl/rockchip/Makefile drivers/pinctrl/rockchip/pinctrl-rk3576.c drivers/pinctrl/rockchip/pinctrl-rockchip.h+282 -01 reply
5/15clk: rockchip: Add rk3576 clk supportarch/arm/include/asm/arch-rockchip/cru_rk3576.h drivers/clk/rockchip/Makefile drivers/clk/rockchip/clk_rk3576.c+3005 -01 reply
6/15reset: rockchip: implement rk3576 lookup tablearch/arm/include/asm/arch-rockchip/clock.h drivers/reset/Makefile drivers/reset/rst-rk3576.c+658 -11 reply
7/15ram: rockchip: Add rk3576 ddr driver supportdrivers/ram/rockchip/Makefile drivers/ram/rockchip/sdram_rk3576.c+36 -01 reply
8/15rockchip: otp: Add support for RK3576drivers/misc/rockchip-otp.c+11 -01 reply
9/15mmc: rockchip_sdhci: Add support for RK3576drivers/mmc/rockchip_sdhci.c+15 -01 reply
10/15mmc: rockchip_dw_mmc: Add support for rk3576drivers/mmc/rockchip_dw_mmc.c+1 -01 reply
11/15net: dwc_eth_qos_rockchip: Add support for RK3576drivers/net/dwc_eth_qos.c drivers/net/dwc_eth_qos_rockchip.c+157 -11 reply
12/15arm64: dts: rockchip: add rk3576 otp nodedts/upstream/src/arm64/rockchip/rk3576.dtsi+39 -01 reply
13/15dt-bindings: arm: rockchip: Add Firefly ROC-RK3576-PC bindingdts/upstream/Bindings/arm/rockchip.yaml+5 -01 reply
14/15arm64: dts: rockchip: Add devicetree for the ROC-RK3576-PCdts/upstream/src/arm64/rockchip/rk3576-roc-pc.dts+736 -01 reply
15/15rockchip: rk3576: Add support for ROC-RK3576-PC boardarch/arm/dts/rk3576-roc-pc-u-boot.dtsi arch/arm/mach-rockchip/rk3576/Kconfig board/firefly/roc-pc-rk3576/Kconfig +4 more+101 -01 reply

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchJonas KarlmanQuentin SchulzJaehoon ChungRob Herring (Arm)Nicolas FrattaroliKever Yang
1/15R-b R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b R-b
10/15R-b R-b R-b
11/15R-b R-b
12/15T-b R-b
13/15A-b R-b
14/15R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/15] Support for the RK3576

This adds support for the RK3576 SoC from Rockchip.

Currently supported (and tested) features are accessing and reading from sdhci and sdmmc devices as well as pxe-booting via the network interface.

As can be seen by the DONOTMERGE labels, this needs to wait a bit still.

The core RK3576 devicetrees will be part of 6.13-rc1, but the Firefly board I only submitted last week, so this would only appear in 6.14-rc1 .

If someone from Collabora could provide a board patch for the ArmSom board they are working with, this would speed things up a bit ;-) .

Checkpatch seems mostly happy too.

changes in v2:
- rebase on top of rockchip-for-next (including the rk3528 addition)
- drop patches now coming from mainline Linux
- cherry pick the now mainline comits for roc-rk3576-pc board and otp
- nitpicks in CFG_SYS_SDRAM_BASE handling (Quentin, Jonas)
- fold in Jonas' fixes for (roc-rk3576-pc board, dwc_eth, sdhci, pinctrl, clk, ram, rk3576-core), they all look nice and also match the review comments submitted.
- add received reviewed-bys for sdhci and mmc

changes in v3:
- drop unneeded syscon-ids
- drop !XPL_BULLD limit from rk3576_common.h
- drop nr_pins from pinctrl
- move SYS_CONFIG_NAME symbol in rk3576/Kconfig
- one more CFG_SYS_SDRAM_BASE nitpick :-)

Elaine Zhang (2):
clk: rockchip: Add rk3576 clk support
reset: rockchip: implement rk3576 lookup table

Heiko Stuebner (10):
rockchip: sdram: honor CFG_SYS_SDRAM_BASE when defining ram regions
ram: rockchip: Add rk3576 ddr driver support
rockchip: otp: Add support for RK3576
mmc: rockchip_sdhci: Add support for RK3576
mmc: rockchip_dw_mmc: Add support for rk3576
net: dwc_eth_qos_rockchip: Add support for RK3576
arm64: dts: rockchip: add rk3576 otp node
dt-bindings: arm: rockchip: Add Firefly ROC-RK3576-PC binding
arm64: dts: rockchip: Add devicetree for the ROC-RK3576-PC
rockchip: rk3576: Add support for ROC-RK3576-PC board

Steven Liu (1):
pinctrl: rockchip: support rk3576 pinctrl

Xuhui Lin (2):
rockchip: mkimage: Add rk3576 support
arm: rockchip: Add RK3576 arch core support

 arch/arm/dts/rk3576-roc-pc-u-boot.dtsi        |   11 +
 arch/arm/dts/rk3576-u-boot.dtsi               |  131 +
 arch/arm/include/asm/arch-rk3576/boot0.h      |   11 +
 arch/arm/include/asm/arch-rk3576/gpio.h       |   11 +
 arch/arm/include/asm/arch-rockchip/clock.h    |   10 +
 .../include/asm/arch-rockchip/cru_rk3576.h    |  491 ++++
 arch/arm/mach-rockchip/Kconfig                |   51 +
 arch/arm/mach-rockchip/Makefile               |    1 +
 arch/arm/mach-rockchip/rk3576/Kconfig         |   23 +
 arch/arm/mach-rockchip/rk3576/Makefile        |    9 +
 arch/arm/mach-rockchip/rk3576/clk_rk3576.c    |   18 +
 arch/arm/mach-rockchip/rk3576/rk3576.c        |  155 +
 arch/arm/mach-rockchip/rk3576/syscon_rk3576.c |   22 +
 arch/arm/mach-rockchip/sdram.c                |   13 +-
 board/firefly/roc-pc-rk3576/Kconfig           |   12 +
 board/firefly/roc-pc-rk3576/MAINTAINERS       |    7 +
 configs/roc-pc-rk3576_defconfig               |   45 +
 doc/board/rockchip/rockchip.rst               |   12 +
 drivers/clk/rockchip/Makefile                 |    1 +
 drivers/clk/rockchip/clk_rk3576.c             | 2513 +++++++++++++++++
 drivers/misc/rockchip-otp.c                   |   11 +
 drivers/mmc/rockchip_dw_mmc.c                 |    1 +
 drivers/mmc/rockchip_sdhci.c                  |   15 +
 drivers/net/dwc_eth_qos.c                     |    4 +
 drivers/net/dwc_eth_qos_rockchip.c            |  154 +-
 drivers/pinctrl/rockchip/Makefile             |    1 +
 drivers/pinctrl/rockchip/pinctrl-rk3576.c     |  278 ++
 drivers/pinctrl/rockchip/pinctrl-rockchip.h   |    3 +
 drivers/ram/rockchip/Makefile                 |    1 +
 drivers/ram/rockchip/sdram_rk3576.c           |   35 +
 drivers/reset/Makefile                        |    2 +-
 drivers/reset/rst-rk3576.c                    |  647 +++++
 dts/upstream/Bindings/arm/rockchip.yaml       |    5 +
 .../src/arm64/rockchip/rk3576-roc-pc.dts      |  736 +++++
 dts/upstream/src/arm64/rockchip/rk3576.dtsi   |   39 +
 include/configs/rk3576_common.h               |   41 +
 include/configs/roc-pc-rk3576.h               |   15 +
 tools/rkcommon.c                              |    1 +
 38 files changed, 5528 insertions(+), 8 deletions(-)
 create mode 100644 arch/arm/dts/rk3576-roc-pc-u-boot.dtsi
 create mode 100644 arch/arm/dts/rk3576-u-boot.dtsi
 create mode 100644 arch/arm/include/asm/arch-rk3576/boot0.h
 create mode 100644 arch/arm/include/asm/arch-rk3576/gpio.h
 create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3576.h
 create mode 100644 arch/arm/mach-rockchip/rk3576/Kconfig
 create mode 100644 arch/arm/mach-rockchip/rk3576/Makefile
 create mode 100644 arch/arm/mach-rockchip/rk3576/clk_rk3576.c
 create mode 100644 arch/arm/mach-rockchip/rk3576/rk3576.c
 create mode 100644 arch/arm/mach-rockchip/rk3576/syscon_rk3576.c
 create mode 100644 board/firefly/roc-pc-rk3576/Kconfig
 create mode 100644 board/firefly/roc-pc-rk3576/MAINTAINERS
 create mode 100644 configs/roc-pc-rk3576_defconfig
 create mode 100644 drivers/clk/rockchip/clk_rk3576.c
 create mode 100644 drivers/pinctrl/rockchip/pinctrl-rk3576.c
 create mode 100644 drivers/ram/rockchip/sdram_rk3576.c
 create mode 100644 drivers/reset/rst-rk3576.c
 create mode 100644 dts/upstream/src/arm64/rockchip/rk3576-roc-pc.dts
 create mode 100644 include/configs/rk3576_common.h
 create mode 100644 include/configs/roc-pc-rk3576.h
Signature · 1 line
2.47.2