task work cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | io_uring: make task_work pending check dependent on ring typeio_uring/ | +3 | 0 replies | |
| 2/6 | io_uring: replace defer task_work llist with io_wq_work_listinclude/ io_uring/ io_uring/ | +104 | 5 replies | |
| 3/6 | io_uring/slist: add list-to-list list splice helperio_uring/ | +16 | 0 replies | |
| 4/6 | io_uring: switch non-defer task_work to io_wq_work_listinclude/ io_uring/ io_uring/ +2 more | +116 | 0 replies | |
| 5/6 | io_uring: add __tctx_task_work_run() helperio_uring/ io_uring/ io_uring/ | +16 | 0 replies | |
| 6/6 | io_uring: make __tctx_task_work_run() take an io_wq_work_listio_uring/ io_uring/ io_uring/ | +32 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCHSET for-next 0/6] task work cleanups
Hi,
This patchset gets rid of using llist for handling task_work, for both local and normal task_work. Instead of a lockless list, a normal io_wq_work_list is used and protected by a spinlock. I've done some benchmarking with this, and I only see wins with this - the act of adding or iterating task_work is the same cost, but we get rid of the need to reverse the task_work list, which can be substantial for bursty applications or just generally busy task_work usages.
Patch 2 implements io_wq_work_list handling for deferred task_work, and patch 4 does the same for normal task_work. Patch 6 then also switches SQPOLL to use this scheme, which eliminates the passing around of io_wq_work_node for its retry logic.
Outside of cleaning up this code, it also enables us to potentially implement task_work run capping for normal task_work in the future.
Git tree can be found here:
https://git.kernel.dk/cgit/linux/log/?h=io_uring-defer-tw
include/linux/io_uring_types.h | 17 +- io_uring/io_uring.c | 293 ++++++++++++++++++--------------- io_uring/io_uring.h | 20 ++- io_uring/slist.h | 16 ++ io_uring/sqpoll.c | 20 ++- io_uring/tctx.c | 3 +- 6 files changed, 211 insertions(+), 158 deletions(-)
Signature · 1 line
Jens Axboe