Skip to content

KVM: s390: Couple of small cmpxchg() optimizations

Heiko Carstens kvm linux-s390 lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Replace broken WRITE_ONCE(..., 9) with intended WRITE_ONCE(..., 0).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: s390: Use try_cmpxchg() instead of cmpxchg() loopsarch/s390/kvm/gaccess.c arch/s390/kvm/interrupt.c arch/s390/kvm/kvm-s390.c +1 more+18 -190 replies
2/3KVM: s390: Remove one byte cmpxchg() usagearch/s390/kvm/interrupt.c+2 -110 replies
3/3KVM: s390: Increase size of union sca_utility to four bytesarch/s390/include/asm/kvm_host.h+5 -54 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchClaudio Imbrenda
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] KVM: s390: Couple of small cmpxchg() optimizations

v2:
- Replace broken WRITE_ONCE(..., 9) with intended WRITE_ONCE(..., 0).

v1:
Use try_cmpxchg() instead of cmpxchg() so compilers with flag output operand support (gcc 14 and newer) can generate slightly better code.

Also get rid of two cmpxchg() usages on one/two byte memory areas which generates inefficient code.

bloat-o-meter statistics of the kvm module:

add/remove: 0/0 grow/shrink: 0/11 up/down: 0/-318 (-318)

Function                                     old     new   delta
kvm_s390_handle_wait                         886     880      -6
kvm_s390_gisa_destroy                        226     220      -6
kvm_s390_gisa_clear                           96      90      -6
ipte_unlock                                  380     372      -8
kvm_s390_gisc_unregister                     270     260     -10
kvm_s390_gisc_register                       290     280     -10
gisa_vcpu_kicker                             200     190     -10
account_mem                                  250     232     -18
ipte_lock                                    416     368     -48
kvm_s390_update_topology_change_report       174     122     -52
kvm_s390_clear_local_irqs                    420     276    -144

Total: Before=316521, After=316203, chg -0.10%

Heiko Carstens (3):
KVM: s390: Use try_cmpxchg() instead of cmpxchg() loops
KVM: s390: Remove one byte cmpxchg() usage
KVM: s390: Increase size of union sca_utility to four bytes

 arch/s390/include/asm/kvm_host.h | 10 +++++-----
 arch/s390/kvm/gaccess.c          | 16 ++++++++--------
 arch/s390/kvm/interrupt.c        | 25 ++++++++-----------------
 arch/s390/kvm/kvm-s390.c         |  4 ++--
 arch/s390/kvm/pci.c              |  5 ++---
 5 files changed, 25 insertions(+), 35 deletions(-)
Signature · 1 line
2.45.2