Skip to content

Fix drm RAD print

Wayne Lin dri-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesIn review
  2. v32 patches 1 replySuperseded
  3. v22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/dp_mst: Fix drm RAD printdrivers/gpu/drm/display/drm_dp_mst_topology.c include/drm/display/drm_dp_mst_helper.h+11 -40 replies
2/2drm/dp_mst: Add helper to get port number at specific LCT from RADdrivers/gpu/drm/display/drm_dp_mst_topology.c+20 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLyude Paul
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] Fix drm RAD print

This is v4 of [1], with the following changes:

- Fix warning caught by kernel test robot:
drivers/gpu/drm/display/drm_dp_mst_topology.c: In function 'drm_dp_mst_rad_to_str':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/display/drm_dp_mst_topology.c:201:81: warning: passing argument 2 of 'drm_dp_mst_get_ufp_num_at_lct_from_rad' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

     201 |                 unpacked_rad[i] = drm_dp_mst_get_ufp_num_at_lct_from_rad(i + 1, rad);
         |                                                                                 ^~~
   drivers/gpu/drm/display/drm_dp_mst_topology.c:179:52: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
     179 | drm_dp_mst_get_ufp_num_at_lct_from_rad(u8 lct, u8 *rad)
         |                                                ~~~~^~~

vim +201 drivers/gpu/drm/display/drm_dp_mst_topology.c

193

   194  static int
   195  drm_dp_mst_rad_to_str(const u8 rad[8], u8 lct, char *out, size_t len)
   196  {

197 int i;
198 u8 unpacked_rad[16] = {};
199
200 for (i = 0; i < lct; i++)

Quoted 1 line

201 unpacked_rad[i] = drm_dp_mst_get_ufp_num_at_lct_from_rad(i + 1, rad);

202
203 /* TODO: Eventually add something to printk so we can format the rad
204 * like this: 1.2.3
205 */
206 return snprintf(out, len, "%*phC", lct, unpacked_rad);
207 }
208

Cc Imre Deak <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Lyude Paul <[email protected]>

[1] https://patchwork.freedesktop.org/series/141832/

Wayne Lin (2):
drm/dp_mst: Fix drm RAD print
drm/dp_mst: Add helper to get port number at specific LCT from RAD

 drivers/gpu/drm/display/drm_dp_mst_topology.c | 31 +++++++++++++------
 include/drm/display/drm_dp_mst_helper.h       |  7 +++++
 2 files changed, 28 insertions(+), 10 deletions(-)
Signature · 1 line
2.37.3