Skip to content

KVM: x86: Prep KVM hypercall handling for TDX

Sean Christopherson kvm lkml 1 version Applied

Status from this message: Applied patch 1 to kvm-x86 fixes. I'm going to hold off on the rest until the

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest6 patches 32 repliesApplied

Changes in v4 from the cover letter

- Fix an SEV-* bug where KVM trips the WARN in is_64_bit_mode().
- Add a pile of reworks to (hopefully) avoid as much duplicate code when TDX comes along.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/6KVM: x86: Play nice with protected guests in complete_hypercall_exit()arch/x86/kvm/x86.c+1 -14 replies
2/6KVM: x86: Add a helper to check for user interception of KVM hypercallsarch/x86/kvm/svm/sev.c arch/x86/kvm/x86.c arch/x86/kvm/x86.h+8 -31 reply
3/6KVM: x86: Move "emulate hypercall" function declarations to x86.harch/x86/include/asm/kvm_host.h arch/x86/kvm/x86.h+6 -63 replies
4/6KVM: x86: Bump hypercall stat prior to fully completing hypercallarch/x86/kvm/x86.c+2 -24 replies
5/6KVM: x86: Always complete hypercall via function callbackarch/x86/kvm/x86.c arch/x86/kvm/x86.h+18 -215 replies
6/6KVM: x86: Refactor __kvm_emulate_hypercall() into a macroarch/x86/kvm/x86.c arch/x86/kvm/x86.h+29 -259 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIsaku YamahataKai HuangXiaoyao LiNikunj A DadhaniaTom LendackyBinbin Wu
SeriesR-b
1/6R-b R-b R-b R-b
2/6R-b R-b R-b R-b
3/6R-b R-b R-b
4/6R-b R-b R-b
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX

Effectively v4 of Binbin's series to handle hypercall exits to userspace in a generic manner, so that TDX

Binbin and Kai, this is fairly different that what we last discussed. While sorting through Binbin's latest patch, I stumbled on what I think/hope is an approach that will make life easier for TDX. Rather than have common code set the return value, _and_ have TDX implement a callback to do the same for user return MSRs, just use the callback for all paths.

As for abusing vcpu->run->hypercall.ret... It's obviously a bit gross, but I think it's a lesser evil than having multiple a one-line wrappers just to trampoline in the return code.

v4:
- Fix an SEV-* bug where KVM trips the WARN in is_64_bit_mode().
- Add a pile of reworks to (hopefully) avoid as much duplicate code when TDX comes along.

v3: https://lore.kernel.org/all/[email protected]

Binbin Wu (1):
KVM: x86: Add a helper to check for user interception of KVM
hypercalls

Sean Christopherson (5):
KVM: x86: Play nice with protected guests in complete_hypercall_exit()
KVM: x86: Move "emulate hypercall" function declarations to x86.h
KVM: x86: Bump hypercall stat prior to fully completing hypercall
KVM: x86: Always complete hypercall via function callback
KVM: x86: Refactor __kvm_emulate_hypercall() into a macro

 arch/x86/include/asm/kvm_host.h |  6 ----
 arch/x86/kvm/svm/sev.c          |  4 +--
 arch/x86/kvm/x86.c              | 50 +++++++++++----------------------
 arch/x86/kvm/x86.h              | 28 ++++++++++++++++++
 4 files changed, 47 insertions(+), 41 deletions(-)

base-commit: 4d911c7abee56771b0219a9fbf0120d06bdc9c14

Signature · 1 line
2.47.0.338.g60cca15819-goog