Skip to content

a whole raft of bugfixes

Kent Overstreet linux-bcachefs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest34 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34bcachefs: BCH_ERR_btree_node_read_error_cachedfs/bcachefs/btree_cache.c fs/bcachefs/errcode.h+4 -30 replies
2/34bcachefs: Use separate rhltable for bch2_inode_or_descendents_is_open()fs/bcachefs/bcachefs.h fs/bcachefs/fs.c fs/bcachefs/fs.h+32 -90 replies
3/34bcachefs: errcode cleanup: journal errorsfs/bcachefs/errcode.h fs/bcachefs/journal.c fs/bcachefs/journal.h+5 -30 replies
4/34bcachefs: disk_accounting: bch2_dev_rcu -> bch2_dev_rcu_noerrorfs/bcachefs/disk_accounting.c fs/bcachefs/disk_accounting.h+3 -30 replies
5/34bcachefs: Fix accounting_read when we rewindfs/bcachefs/disk_accounting.c+15 -00 replies
6/34bcachefs: backpointer_to_missing_ptr is now autofixfs/bcachefs/sb-errors_format.h+1 -10 replies
7/34bcachefs: Fix btree node scan when unknown btree IDs are presentfs/bcachefs/btree_cache.c fs/bcachefs/btree_cache.h+15 -50 replies
8/34bcachefs: Kill bch2_bucket_alloc_new_fs()fs/bcachefs/alloc_foreground.c fs/bcachefs/alloc_foreground.h fs/bcachefs/bcachefs.h +6 more+66 -770 replies
9/34bcachefs: Bad btree roots are now autofixfs/bcachefs/sb-errors_format.h+2 -20 replies
10/34bcachefs: Fix dup/misordered check in btree node readfs/bcachefs/btree_io.c+9 -10 replies
11/34bcachefs: Don't try to en/decrypt when encryption not availablefs/bcachefs/btree_io.c fs/bcachefs/btree_node_scan.c fs/bcachefs/checksum.c +2 more+83 -610 replies
12/34bcachefs: Change "disk accounting version 0" check to commit onlyfs/bcachefs/disk_accounting.c+2 -10 replies
13/34bcachefs: Fix bch2_btree_node_update_key_early()fs/bcachefs/btree_cache.c+1 -10 replies
14/34bcachefs: Go RW earlier, for normal rw mountfs/bcachefs/recovery_passes.c+1 -10 replies
15/34bcachefs: Fix null ptr deref in btree_path_lock_root()fs/bcachefs/btree_iter.c+8 -30 replies
16/34bcachefs: Ignore empty btree root journal entriesfs/bcachefs/recovery.c+7 -90 replies
17/34bcachefs: struct bkey_validate_contextfs/bcachefs/alloc_background.c fs/bcachefs/alloc_background.h fs/bcachefs/backpointers.c +36 more+231 -1420 replies
18/34bcachefs: Make topology errors autofixfs/bcachefs/btree_gc.c fs/bcachefs/recovery.c fs/bcachefs/sb-errors_format.h+32 -130 replies
19/34bcachefs: BCH_FS_recovery_runningfs/bcachefs/bcachefs.h fs/bcachefs/error.c fs/bcachefs/recovery.c+4 -10 replies
20/34bcachefs: dio write: Take ref on mm_struct when using asynchronouslyfs/bcachefs/fs-io-direct.c+36 -62 replies
21/34bcachefs: Guard against journal seq overflowfs/bcachefs/journal.c fs/bcachefs/journal_types.h+12 -00 replies
22/34bcachefs: Issue a transaction restart after commit in repairfs/bcachefs/alloc_background.c fs/bcachefs/errcode.h+2 -10 replies
23/34bcachefs: Guard against backpointers to unknown btreesfs/bcachefs/backpointers.c fs/bcachefs/sb-errors_format.h+6 -30 replies
24/34bcachefs: Fix journal_iter list corruptionfs/bcachefs/btree_update_interior.c+5 -50 replies
25/34bcachefs: add missing printbuf_reset()fs/bcachefs/btree_gc.c+1 -00 replies
26/34bcachefs: mark more errors AUTOFIXfs/bcachefs/sb-errors_format.h+4 -40 replies
27/34bcachefs: Don't error out when logging fsck errorfs/bcachefs/alloc_background.c fs/bcachefs/error.c fs/bcachefs/error.h+31 -200 replies
28/34bcachefs: do_fsck_ask_yn()fs/bcachefs/error.c+34 -250 replies
29/34bcachefs: Check for bucket journal seq in the futurefs/bcachefs/alloc_background.c fs/bcachefs/sb-errors_format.h+37 -290 replies
30/34bcachefs: Check for inode journal seq in the futurefs/bcachefs/fs-io.c fs/bcachefs/fsck.c fs/bcachefs/sb-errors_format.h+46 -50 replies
31/34bcachefs: cryptographic MACs on superblock are not (yet?) supportedfs/bcachefs/super-io.c+2 -10 replies
32/34bcachefs: bch2_trans_relock() is trylock for lockdepfs/bcachefs/btree_iter.c fs/bcachefs/btree_locking.c fs/bcachefs/btree_locking.h+7 -70 replies
33/34bcachefs: Check for extent crc uncompressed/compressed size mismatchfs/bcachefs/extents.c fs/bcachefs/sb-errors_format.h+16 -110 replies
34/34bcachefs: Don't recurse in check_discard_freespace_keyfs/bcachefs/alloc_background.c fs/bcachefs/alloc_background.h fs/bcachefs/alloc_foreground.c +1 more+67 -100 replies

Reviews trailers per patch

1 of 34 patches has a Reviewed-by or Acked-by.

PatchJens Axboe
1/34
2/34
3/34
4/34
5/34
6/34
7/34
8/34
9/34
10/34
11/34
12/34
13/34
14/34
15/34
16/34
17/34
18/34
19/34
20/34R-b
21/34
22/34
23/34
24/34
25/34
26/34
27/34
28/34
29/34
30/34
31/34
32/34
33/34
34/34

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/34] a whole raft of bugfixes

mostly syzbot stuff

"use separate rhltable for inode_or_descendents is open" addresses livelocks people were seeing when something scanned all their snapshots

"Change "disk accounting version 0" check to commit only" addresses "invalid bkey" errors some people have been seeing after upgrading to 6.12

Kent Overstreet (34):
bcachefs: BCH_ERR_btree_node_read_error_cached
bcachefs: Use separate rhltable for
bch2_inode_or_descendents_is_open()
bcachefs: errcode cleanup: journal errors
bcachefs: disk_accounting: bch2_dev_rcu -> bch2_dev_rcu_noerror
bcachefs: Fix accounting_read when we rewind
bcachefs: backpointer_to_missing_ptr is now autofix
bcachefs: Fix btree node scan when unknown btree IDs are present
bcachefs: Kill bch2_bucket_alloc_new_fs()
bcachefs: Bad btree roots are now autofix
bcachefs: Fix dup/misordered check in btree node read
bcachefs: Don't try to en/decrypt when encryption not available
bcachefs: Change "disk accounting version 0" check to commit only
bcachefs: Fix bch2_btree_node_update_key_early()
bcachefs: Go RW earlier, for normal rw mount
bcachefs: Fix null ptr deref in btree_path_lock_root()
bcachefs: Ignore empty btree root journal entries
bcachefs: struct bkey_validate_context
bcachefs: Make topology errors autofix
bcachefs: BCH_FS_recovery_running
bcachefs: dio write: Take ref on mm_struct when using asynchronously
bcachefs: Guard against journal seq overflow
bcachefs: Issue a transaction restart after commit in repair
bcachefs: Guard against backpointers to unknown btrees
bcachefs: Fix journal_iter list corruption
bcachefs: add missing printbuf_reset()
bcachefs: mark more errors AUTOFIX
bcachefs: Don't error out when logging fsck error
bcachefs: do_fsck_ask_yn()
bcachefs: Check for bucket journal seq in the future
bcachefs: Check for inode journal seq in the future
bcachefs: cryptographic MACs on superblock are not (yet?) supported
bcachefs: bch2_trans_relock() is trylock for lockdep
bcachefs: Check for extent crc uncompressed/compressed size mismatch
bcachefs: Don't recurse in check_discard_freespace_key

 fs/bcachefs/alloc_background.c      | 153 ++++++++++++++++++-------
 fs/bcachefs/alloc_background.h      |  18 +--
 fs/bcachefs/alloc_foreground.c      |  42 +++----
 fs/bcachefs/alloc_foreground.h      |   2 -
 fs/bcachefs/backpointers.c          |   9 +-
 fs/bcachefs/backpointers.h          |   3 +-
 fs/bcachefs/bcachefs.h              |   4 +-
 fs/bcachefs/bkey.h                  |   7 --
 fs/bcachefs/bkey_methods.c          |  29 ++---
 fs/bcachefs/bkey_methods.h          |  15 +--
 fs/bcachefs/bkey_types.h            |  26 +++++
 fs/bcachefs/btree_cache.c           |  19 ++--
 fs/bcachefs/btree_cache.h           |   9 +-
 fs/bcachefs/btree_gc.c              |   3 +-
 fs/bcachefs/btree_io.c              | 170 +++++++++++++++++-----------
 fs/bcachefs/btree_iter.c            |  19 ++--
 fs/bcachefs/btree_locking.c         |   2 +-
 fs/bcachefs/btree_locking.h         |   4 +-
 fs/bcachefs/btree_node_scan.c       |  10 +-
 fs/bcachefs/btree_trans_commit.c    |   7 +-
 fs/bcachefs/btree_update_interior.c |  21 ++--
 fs/bcachefs/buckets.c               |  25 ++++
 fs/bcachefs/buckets.h               |  21 +---
 fs/bcachefs/checksum.c              |  10 +-
 fs/bcachefs/data_update.c           |   7 +-
 fs/bcachefs/dirent.c                |   4 +-
 fs/bcachefs/dirent.h                |   4 +-
 fs/bcachefs/disk_accounting.c       |  24 +++-
 fs/bcachefs/disk_accounting.h       |   5 +-
 fs/bcachefs/ec.c                    |   4 +-
 fs/bcachefs/ec.h                    |   5 +-
 fs/bcachefs/errcode.h               |   5 +
 fs/bcachefs/error.c                 | 110 +++++++++++-------
 fs/bcachefs/error.h                 |  18 +--
 fs/bcachefs/extents.c               |  40 ++++---
 fs/bcachefs/extents.h               |   9 +-
 fs/bcachefs/fs-io-direct.c          |  42 ++++++-
 fs/bcachefs/fs-io.c                 |  35 +++++-
 fs/bcachefs/fs.c                    |  39 +++++--
 fs/bcachefs/fs.h                    |   1 +
 fs/bcachefs/fsck.c                  |  13 ++-
 fs/bcachefs/inode.c                 |  16 +--
 fs/bcachefs/inode.h                 |   9 +-
 fs/bcachefs/io_read.c               |  14 ++-
 fs/bcachefs/journal.c               |  47 ++++----
 fs/bcachefs/journal.h               |   2 +-
 fs/bcachefs/journal_io.c            |  35 +++---
 fs/bcachefs/journal_reclaim.c       |   3 +
 fs/bcachefs/journal_types.h         |   3 +
 fs/bcachefs/lru.c                   |   2 +-
 fs/bcachefs/lru.h                   |   2 +-
 fs/bcachefs/quota.c                 |   2 +-
 fs/bcachefs/quota.h                 |   4 +-
 fs/bcachefs/recovery.c              |  55 +++++----
 fs/bcachefs/recovery_passes.c       |   2 +-
 fs/bcachefs/reflink.c               |   8 +-
 fs/bcachefs/reflink.h               |  10 +-
 fs/bcachefs/sb-errors_format.h      |  35 +++---
 fs/bcachefs/snapshot.c              |   4 +-
 fs/bcachefs/snapshot.h              |   7 +-
 fs/bcachefs/subvolume.c             |   2 +-
 fs/bcachefs/subvolume.h             |   5 +-
 fs/bcachefs/super-io.c              |   3 +-
 fs/bcachefs/super.c                 |  12 +-
 fs/bcachefs/xattr.c                 |   2 +-
 fs/bcachefs/xattr.h                 |   3 +-
 66 files changed, 822 insertions(+), 458 deletions(-)
Signature · 1 line
2.45.2