Skip to content

Client-side OFFLOAD_STATUS implementation

[email protected] linux-nfs 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 0 repliesNew
  2. v37 patches 3 repliesSuperseded
  3. v27 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Change to fixed lease_time/2 timeout before posting OFFLOAD_STATUS
- Check if CB_OFFLOAD arrived if OFFLOAD_STATUS returned BAD_STATEID
- Added Olga's R-b and T-b tags

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7NFS: CB_OFFLOAD can return NFS4ERR_DELAYfs/nfs/callback_proc.c+1 -10 replies
2/7NFS: Fix typo in OFFLOAD_CANCEL commentfs/nfs/nfs42xdr.c+1 -10 replies
3/7NFS: Rename struct nfs4_offloadcancel_datafs/nfs/nfs42proc.c+9 -90 replies
4/7NFS: Implement NFSv4.2's OFFLOAD_STATUS XDRfs/nfs/nfs42xdr.c fs/nfs/nfs4xdr.c include/linux/nfs4.h +1 more+91 -20 replies
5/7NFS: Implement NFSv4.2's OFFLOAD_STATUS operationfs/nfs/nfs42proc.c fs/nfs/nfs4proc.c include/linux/nfs_fs_sb.h+108 -10 replies
6/7NFS: Use NFSv4.2's OFFLOAD_STATUS operationfs/nfs/nfs42proc.c+62 -110 replies
7/7NFS: Refactor trace_nfs4_offload_cancelfs/nfs/nfs42proc.c fs/nfs/nfs4trace.h+11 -10 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJeff LaytonBenjamin CoddingtonOlga Kornievskaia
1/7R-b R-b R-b T-b
2/7R-b R-b R-b T-b
3/7R-b R-b R-b T-b
4/7R-b R-b R-b T-b
5/7R-b R-b R-b T-b
6/7R-b R-b R-b T-b
7/7R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/7] Client-side OFFLOAD_STATUS implementation

From: Chuck Lever <[email protected]>

SCSI implementation experience has shown that an interrupt-only COPY offload implementation is not reliable. There are too many common scenarios where the client can miss the completion interrupt (in our case, this is an NFSv4.2 CB_OFFLOAD callback).

Therefore, a polling mechanism is needed. The NFSv4.2 protocol provides one in the form of the its OFFLOAD_STATUS operation. Linux NFSD implements OFFLOAD_STATUS already. This series adds a Linux NFS client implementation of the OFFLOAD_STATUS operation that can query the state of a background COPY on the server.

These patches are also available here:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=fix-async-copy

Changes since v3:
- Change to fixed lease_time/2 timeout before posting OFFLOAD_STATUS
- Check if CB_OFFLOAD arrived if OFFLOAD_STATUS returned BAD_STATEID
- Added Olga's R-b and T-b tags

Chuck Lever (7):
NFS: CB_OFFLOAD can return NFS4ERR_DELAY
NFS: Fix typo in OFFLOAD_CANCEL comment
NFS: Rename struct nfs4_offloadcancel_data
NFS: Implement NFSv4.2's OFFLOAD_STATUS XDR
NFS: Implement NFSv4.2's OFFLOAD_STATUS operation
NFS: Use NFSv4.2's OFFLOAD_STATUS operation
NFS: Refactor trace_nfs4_offload_cancel

 fs/nfs/callback_proc.c    |   2 +-
 fs/nfs/nfs42proc.c        | 195 ++++++++++++++++++++++++++++++++++----
 fs/nfs/nfs42xdr.c         |  88 ++++++++++++++++-
 fs/nfs/nfs4proc.c         |   3 +-
 fs/nfs/nfs4trace.h        |  11 ++-
 fs/nfs/nfs4xdr.c          |   1 +
 include/linux/nfs4.h      |   1 +
 include/linux/nfs_fs_sb.h |   1 +
 include/linux/nfs_xdr.h   |   5 +-
 9 files changed, 282 insertions(+), 25 deletions(-)
Signature · 1 line
2.47.0