Skip to content

irqchip: MSI parent cleanup and PCI host driver conversion

Marc Zyngier linux-arm-kernel linux-pci lkml 2 versions – Applied

Status from this message: The following commit has been merged into the irq/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 4 repliesApplied
  2. v111 patches 2 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9irqchip: Make irq-msi-lib.h globally availabledrivers/irqchip/irq-bcm2712-mip.c drivers/irqchip/irq-gic-v2m.c drivers/irqchip/irq-gic-v3-its-msi-parent.c +13 more+18 -180 replies
2/9genirq/msi: Add helper for creating MSI-parent irq domainsinclude/linux/msi.h kernel/irq/msi.c+30 -00 replies
3/9irqchip/gic: Convert to msi_create_parent_irq_domain() helperdrivers/irqchip/irq-gic-v2m.c drivers/irqchip/irq-gic-v3-its.c drivers/irqchip/irq-gic-v3-mbi.c+22 -203 replies
4/9irqchip/mvebu: Convert to msi_create_parent_irq_domain() helperdrivers/irqchip/irq-mvebu-gicp.c drivers/irqchip/irq-mvebu-odmi.c drivers/irqchip/irq-mvebu-sei.c+20 -240 replies
5/9irqchip: Drop MSI_CHIP_FLAG_SET_ACK from unsuspecting MSI driversdrivers/irqchip/irq-gic-v2m.c drivers/irqchip/irq-gic-v3-its-msi-parent.c drivers/irqchip/irq-gic-v3-mbi.c +2 more+5 -50 replies
6/9irqchip/msi-lib: Honour the MSI_FLAG_NO_AFFINITY flagdrivers/irqchip/irq-msi-lib.c+6 -10 replies
7/9PCI: apple: Convert to MSI parent infrastructuredrivers/pci/controller/Kconfig drivers/pci/controller/pcie-apple.c+22 -411 reply
8/9PCI: xgene: Convert to MSI parent infrastructuredrivers/pci/controller/Kconfig drivers/pci/controller/pci-xgene-msi.c+18 -290 replies
9/9PCI: tegra: Convert to MSI parent infrastructuredrivers/pci/controller/Kconfig drivers/pci/controller/pci-tegra.c+19 -420 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchAlyssa Rosenzweig
1/9
2/9
3/9
4/9
5/9
6/9
7/9A-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] irqchip: MSI parent cleanup and PCI host driver conversion

This is v2 of a series I posted[1] a few months back before running out of time, energy, and interest. I have now reduced it to the stuff I actually care about, and got rid of all things non-arm64.

I've become annoyed by the couple of machines I have around that haven't been converted to the per-device MSI infrastructure. At the same time, I've also moaned at the amount of boilerplate code required to make use of this infrastructure.

This series therefore does a number of things:

- make irq-msi-lib.h globally available, so that PCI (and other subsystems) may make use of it

- add a new helper (msi_create_parent_irq_domain()) that encapsulates most of the magic required to create an MSI-parent domain

- convert the arm64 I have access to (and *only* that)

- convert the Apple, XGene and Tegra MSI drivers to the MSI-parent infrastructure, which is why I came here the first place.

* From v1 [1]:

- use irq_domain_info as an the holder of most information required to instantiate the domain. I decided against using a specific structure, because they would mostly have the same fields.

- added a patch to convert the Tegra driver, which required dealing with the MSI_FLAG_NO_AFFINITY flag

- got rid of x86 and riscv patches (life is too short).

[1] https://lore.kernel.org/all/[email protected]

Marc Zyngier (9):
irqchip: Make irq-msi-lib.h globally available genirq/msi: Add helper for creating MSI-parent irq domains irqchip/gic: Convert to msi_create_parent_irq_domain() helper irqchip/mvebu: Convert to msi_create_parent_irq_domain() helper
irqchip: Drop MSI_CHIP_FLAG_SET_ACK from unsuspecting MSI drivers irqchip/msi-lib: Honour the MSI_FLAG_NO_AFFINITY flag
PCI: apple: Convert to MSI parent infrastructure
PCI: xgene: Convert to MSI parent infrastructure
PCI: tegra: Convert to MSI parent infrastructure

 drivers/irqchip/irq-bcm2712-mip.c             |  2 +-
 drivers/irqchip/irq-gic-v2m.c                 | 16 ++---
 drivers/irqchip/irq-gic-v3-its-msi-parent.c   |  4 +-
 drivers/irqchip/irq-gic-v3-its.c              | 21 +++----
 drivers/irqchip/irq-gic-v3-mbi.c              | 15 ++---
 drivers/irqchip/irq-imx-mu-msi.c              |  2 +-
 drivers/irqchip/irq-loongarch-avec.c          |  2 +-
 drivers/irqchip/irq-loongson-pch-msi.c        |  2 +-
 drivers/irqchip/irq-msi-lib.c                 |  9 ++-
 drivers/irqchip/irq-mvebu-gicp.c              | 18 +++---
 drivers/irqchip/irq-mvebu-icu.c               |  2 +-
 drivers/irqchip/irq-mvebu-odmi.c              | 18 +++---
 drivers/irqchip/irq-mvebu-sei.c               | 18 +++---
 drivers/irqchip/irq-riscv-imsic-platform.c    |  2 +-
 drivers/irqchip/irq-sg2042-msi.c              |  2 +-
 drivers/pci/controller/Kconfig                |  3 +
 drivers/pci/controller/pci-tegra.c            | 60 ++++++------------
 drivers/pci/controller/pci-xgene-msi.c        | 46 +++++---------
 drivers/pci/controller/pcie-apple.c           | 62 +++++++------------
 .../linux}/irqchip/irq-msi-lib.h              |  6 +-
 include/linux/msi.h                           |  4 ++
 kernel/irq/msi.c                              | 26 ++++++++
 22 files changed, 160 insertions(+), 180 deletions(-)
 rename {drivers => include/linux}/irqchip/irq-msi-lib.h (84%)
Signature · 1 line
2.39.2