Skip to content

readahead: Reintroduce fix for improper RA window sizing

Jan Kara linux-fsdevel linux-mm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew 1 of 2 applied

Patches in v1 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2readahead: Don't shorted readahead window in read_pages()mm/readahead.c+2 -120 replies
2/2readahead: properly shorten readahead when falling back to do_page_cache_ra()mm/readahead.c+10 -30 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] readahead: Reintroduce fix for improper RA window sizing

Hello,

this small patch series reintroduces a fix of readahead window confusion (and thus read throughput reduction) when page_cache_ra_order() ends up failing due to folios already present in the page cache. After thinking about this for a while I have ended up with a dumb fix that just rechecks if we have something to read before calling do_page_cache_ra(). This fixes the problem reported in [1]. I still think it doesn't make much sense to update readahead window size in read_pages() so patch 1 removes that but the real fix in patch 2 does not depend on it.

Patches are based on top of my revert that's in MM tree as of today but I expect it lands in Linus' tree very soon.

Honza

[1] https://lore.kernel.org/all/[email protected]